Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup id ref. Use type views instead. #4650

Merged
merged 2 commits into from
Dec 13, 2021
Merged

Cleanup id ref. Use type views instead. #4650

merged 2 commits into from
Dec 13, 2021

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Dec 7, 2021

Also use extension facility

@bmarty bmarty force-pushed the feature/bma/id_ref branch from cb35459 to d3a1746 Compare December 7, 2021 15:56
@github-actions
Copy link

github-actions bot commented Dec 7, 2021 •
edited
Loading

Unit Test Results

  66 files  ±0    66 suites  ±0   1m 3s ⏱️ +4s
135 tests ±0  135 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
418 runs  ±0  418 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a090642. ± Comparison against base commit 147935d.

♻️ This comment has been updated with latest results.

@ouchadam
Copy link
Contributor

something else to look into could be using a non transitive R file https://blog.blundellapps.co.uk/speed-up-your-build-non-transitive-r-files/ although this will mostly benefit us when we have more modules

@bmarty bmarty mentioned this pull request Dec 13, 2021
Open
@bmarty bmarty merged commit 3620a26 into develop Dec 13, 2021
@bmarty bmarty deleted the feature/bma/id_ref branch December 13, 2021 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ouchadam ouchadam ouchadam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmarty @ouchadam