Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade OLM to v3.2.7 and get it from our maven repository. #4647

Merged
merged 1 commit into from
Dec 7, 2021

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Dec 7, 2021

Get OLM library from our maven repository, and upgrade it from 3.2.4 to 3.2.7

Related: https://gitlab.matrix.org/matrix-org/olm/-/issues/5 and following instruction from https://gitlab.matrix.org/matrix-org/olm/-/packages/43 .

Issue like that should not happen anymore #3150 #4271

Dependabot should be able to create PR for automatic update of the lib 🤞

@bmarty bmarty requested review from uhoreg and BillCarsonFr December 7, 2021 13:49
@bmarty bmarty force-pushed the feature/bma/olm_on_maven branch from 96da185 to 892d708 Compare December 7, 2021 13:50
Copy link
Member

@uhoreg uhoreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks plausible

Copy link
Contributor

@ouchadam ouchadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from a gradle perspective LGTM (assuming the CI is happy and there's no breaking api changes)

Copy link
Member

@BillCarsonFr BillCarsonFr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@github-actions
Copy link

github-actions bot commented Dec 7, 2021

Unit Test Results

  66 files  ±0    66 suites  ±0   51s ⏱️ -3s
135 tests ±0  135 ✔️ ±0  0 💤 ±0  0 ±0 
418 runs  ±0  418 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 892d708. ± Comparison against base commit 53e4ef5.

@bmarty bmarty merged commit 147935d into develop Dec 7, 2021
@bmarty bmarty deleted the feature/bma/olm_on_maven branch December 7, 2021 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants