Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup onclick #4645

Merged
merged 7 commits into from
Dec 7, 2021
Merged

Cleanup onclick #4645

merged 7 commits into from
Dec 7, 2021

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Dec 6, 2021

See commit comments for more details

@github-actions
Copy link

github-actions bot commented Dec 6, 2021

Unit Test Results

  66 files  ±0    66 suites  ±0   49s ⏱️ -14s
135 tests ±0  135 ✔️ ±0  0 💤 ±0  0 ±0 
418 runs  ±0  418 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 7a77ae4. ± Comparison against base commit f1d8b9e.

@@ -121,7 +120,6 @@ abstract class VectorBaseActivity<VB : ViewBinding> : AppCompatActivity(), Maver

protected fun View.debouncedClicks(onClicked: () -> Unit) {
clicks()
.throttleFirst(300)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 this should help make the app feel a little snappier (if I've understood the current usages)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it is not delaying the first click hopefully, but just ignore the next ones in a 300ms window

Copy link
Contributor

@ouchadam ouchadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bmarty bmarty merged commit 74355ae into develop Dec 7, 2021
@bmarty bmarty deleted the feature/bma/cleanupOnclick branch December 7, 2021 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants