Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove not needed Job canceling in viewModel onCleared() function #4602

Closed
ariskotsomitopoulos opened this issue Dec 1, 2021 · 1 comment
Closed

Remove not needed Job canceling in viewModel onCleared() function #4602

ariskotsomitopoulos opened this issue Dec 1, 2021 · 1 comment
Assignees
@ariskotsomitopoulos
Labels
A-Developer-Experience T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@ariskotsomitopoulos
Copy link
Contributor

ariskotsomitopoulos commented Dec 1, 2021 •
edited
Loading

There is no need to call job.cancel() when we are using viewModelScope()
@ariskotsomitopoulos ariskotsomitopoulos added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems A-Developer-Experience labels Dec 1, 2021
@ariskotsomitopoulos ariskotsomitopoulos self-assigned this Dec 1, 2021
@ariskotsomitopoulos ariskotsomitopoulos mentioned this issue Dec 1, 2021
Merged
@bmarty
Copy link
Member

bmarty commented Dec 1, 2021

In EA 1.3.10

@bmarty bmarty closed this as completed Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ariskotsomitopoulos ariskotsomitopoulos

Labels
A-Developer-Experience T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bmarty @ariskotsomitopoulos