Android12 #4433

bmarty · 2021-11-09T08:25:59Z

Ok, sanity test is passing (a problem at the end, will run it again), but see 0ecf1a4 to be able to run it.

The PR can be reviewed and CI should be happy now.

Notification are not working on the emulator, I'm testing F-Droid version. Will check on GPlay version, but weird. Quick reply from notification has to be tested because the Pending Intent should be MUTABLE in this case (but now it's IMMUTABLE), see https://developer.android.com/guide/components/intents-filters#CreateImmutablePendingIntents . I wanted to test it before applying the fix.

Edit: This is probably a pb with the emulator (or with my test account?).
The notification troubleshoot is working fine, the PUSH test is received, but take about 20s to come to the app...
Push tested OK on real device with Android 10.
We should merge the PR and see what happen during the next release.

Edit 2: room notification are now working fine thanks to dddcbfb

Fixes #4262

github-actions · 2021-11-09T08:29:42Z

Unit Test Results

  66 files +  4   66 suites +4 55s ⏱️ +3s
135 tests +17 135 ✔️ +17 0 💤 ±0 0 ❌ ±0
418 runs +68 418 ✔️ +68 0 💤 ±0 0 ❌ ±0

Results for commit dddcbfb. ± Comparison against base commit a758225.

♻️ This comment has been updated with latest results.

…et when targeting Android 12 Do it for services coming from dependencies

Bumps work-runtime-ktx from 2.6.0 to 2.7.0. --- updated-dependencies: - dependency-name: androidx.work:work-runtime-ktx dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps lifecycle-livedata-ktx from 2.3.1 to 2.4.0. --- updated-dependencies: - dependency-name: androidx.lifecycle:lifecycle-livedata-ktx dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps core-ktx from 1.6.0 to 1.7.0. --- updated-dependencies: - dependency-name: androidx.core:core-ktx dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps browser from 1.3.0 to 1.4.0. --- updated-dependencies: - dependency-name: androidx.browser:browser dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

See https://developer.android.com/jetpack/androidx/releases/lifecycle#declaring_dependencies

…ycle-common https://developer.android.com/jetpack/androidx/releases/lifecycle#2.4.0

Permission should be granted, according to https://developer.android.com/reference/android/view/OnReceiveContentListener#uri-permissions

java.lang.SecurityException: To use the sampling rate of 0 microseconds, app needs to declare the normal permission HIGH_SAMPLING_RATE_SENSORS.

And make the code more efficient, since we call getColumnIndexOrNull only once and not on each cursor iteration

Ensure that column index is not -1

LiveData value assignment nullability mismatch

I guess we accept only images coming from the keyboard.

…table" Room notifications are now working on Android 12 emulator

ouchadam · 2021-11-16T11:52:34Z

vector/src/main/AndroidManifest.xml

@@ -417,6 +420,22 @@
                android:name="android.support.FILE_PROVIDER_PATHS"
                android:resource="@xml/sdk_provider_paths" />
        </provider>
+
+        <!-- Temporary fix for Android 12. android:exported has to be explicitly set when targeting Android 12
+        Do it for services coming from dependencies - BEGIN -->


💯 hopefully the libraries will update their targets soonish~ (especially androidx)

Yes. Jitsi lib has not been upgrading since a while, and it requires some manual steps. See https://github.com/vector-im/element-android/blob/main/docs/jitsi.md if you are curious (I know you are :) )

ouchadam · 2021-11-16T11:58:40Z

multipicker/src/main/java/im/vector/lib/multipicker/ContactPicker.kt

-                            while (cursor.moveToNext()) {
-                                val mimeType = cursor.getString(cursor.getColumnIndex(ContactsContract.Data.MIMETYPE))
-                                val contactData = cursor.getString(cursor.getColumnIndex(ContactsContract.Data.DATA1))
+                        )?.use inner@{ innerCursor ->


this is my first time seeing inner@{, what does it do?

"inner" is just a label, it could be anything else. It allows to use return@inner below (lines 77 and 78). Using classical return@use is not possible there since we are in 2 nested use blocks, so is ambiguous.

ah thanks for explaining

ouchadam · 2021-11-16T12:00:26Z

vector/src/main/java/im/vector/app/AppStateHandler.kt

@@ -57,7 +56,7 @@ class AppStateHandler @Inject constructor(
        private val sessionDataSource: ActiveSessionDataSource,
        private val uiStateRepository: UiStateRepository,
        private val activeSessionHolder: ActiveSessionHolder
-) : LifecycleObserver {
+) : DefaultLifecycleObserver {


nice clean up! might speed up the lifecycle KAPT processing a tiny bit as well 🤞

ouchadam · 2021-11-16T12:05:48Z

vector/src/main/java/im/vector/app/features/rageshake/RageShake.kt

@@ -46,7 +46,7 @@ class RageShake @Inject constructor(private val activity: FragmentActivity,

        shakeDetector = ShakeDetector(this).apply {
            setSensitivity(vectorPreferences.getRageshakeSensitivity())
-            start(sensorManager)
+            start(sensorManager, SensorManager.SENSOR_DELAY_GAME)


I don't think we'll have any issues but wanted to highlight this means we've changed fromSENSOR_DELAY_FASTEST to SENSOR_DELAY_GAME

I wonder if SENSOR_DELAY_UI could be more suited? haven't tested, assuming from the docs...

/** get sensor data as fast as possible */ public static final int SENSOR_DELAY_FASTEST = 0; /** rate suitable for games */ public static final int SENSOR_DELAY_GAME = 1; /** rate suitable for the user interface */ public static final int SENSOR_DELAY_UI = **2;**

TBH I haven't checked SENSOR_DELAY_UI. The change was necessary because when using SENSOR_DELAY_FASTEST we need to add a permission in the manifest.
Rageshake still works with SENSOR_DELAY_GAME, I did not investigate more.

ouchadam

awesome stuff! 💯 thanks for updating the blocked dependencies as well

some small comments but no blockers

bmarty marked this pull request as ready for review November 10, 2021 18:39

bmarty and others added 24 commits November 15, 2021 12:24

Target API 31 - Android 12 - #4262

aa3f36b

Temporary fix for Android 12. android:exported has to be explicitly s…

31809a5

…et when targeting Android 12 Do it for services coming from dependencies

Target API 31 - Handle deprecated API

f7b2059

Bump core-ktx from 1.6.0 to 1.7.0

2880798

Bumps core-ktx from 1.6.0 to 1.7.0. --- updated-dependencies: - dependency-name: androidx.core:core-ktx dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bump browser from 1.3.0 to 1.4.0

56776ae

Bumps browser from 1.3.0 to 1.4.0. --- updated-dependencies: - dependency-name: androidx.browser:browser dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

android:exported has to be explicitly set when targeting Android 12

756f846

Same version for all lifecycle deps

a1c8835

androidx.lifecycle:lifecycle-extensions is deprecated

a1630b5

See https://developer.android.com/jetpack/androidx/releases/lifecycle#declaring_dependencies

Add dep for ProcessLifecycleOwner

7e59c18

androidx.lifecycle:lifecycle-common-java8 -> androidx.lifecycle:lifec…

9429b03

…ycle-common https://developer.android.com/jetpack/androidx/releases/lifecycle#2.4.0

@OnLifecycleEvent is deprecated, use DefaultLifecycleObserver instead

0a9845a

InputConnectionCompat.createWrapper is deprecated

e9f53f6

Permission should be granted, according to https://developer.android.com/reference/android/view/OnReceiveContentListener#uri-permissions

Fix crash on Android 12

f25c178

java.lang.SecurityException: To use the sampling rate of 0 microseconds, app needs to declare the normal permission HIGH_SAMPLING_RATE_SENSORS.

Fix crash on Android 12: PendingIntent.FLAG_IMMUTABLE has to be set

f88a477

Make the Cursor extensions public

453e6da

And make the code more efficient, since we call getColumnIndexOrNull only once and not on each cursor iteration

Fix lint issue "Outside Range"

03019fd

Ensure that column index is not -1

Fix lint issue "Incorrect constant"

1082771

Fix lint issue "NullSafeMutableLiveData"

96de0f8

LiveData value assignment nullability mismatch

ktlint

b26ea75

Fix crash on Android 12.

60d75ff

I guess we accept only images coming from the keyboard.

Use correct value, but I do not see any effect on emulator with API 12

5a19533

Add comment to run on Android 12

fb8b720

bmarty force-pushed the feature/bma/android12 branch from 0ecf1a4 to fb8b720 Compare November 15, 2021 11:26

bmarty added 3 commits November 15, 2021 21:35

Fix warning after rebase (it's for test, so OK to suppress warning)

eb39b37

Quick fix on this file

8d8565c

Fix "PendingIntents attached to actions with remote inputs must be mu…

dddcbfb

…table" Room notifications are now working on Android 12 emulator

ouchadam reviewed Nov 16, 2021

View reviewed changes

ouchadam approved these changes Nov 16, 2021

View reviewed changes

bmarty merged commit be3aafe into develop Nov 16, 2021

bmarty deleted the feature/bma/android12 branch November 16, 2021 12:27

ouchadam mentioned this pull request Nov 17, 2021

Push notifications sometimes disappear immediately #3996

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Android12 #4433

Android12 #4433

bmarty commented Nov 9, 2021 •

edited

Loading

github-actions bot commented Nov 9, 2021 •

edited

Loading

ouchadam Nov 16, 2021

bmarty Nov 16, 2021

ouchadam Nov 16, 2021 •

edited

Loading

bmarty Nov 16, 2021

ouchadam Nov 16, 2021

ouchadam Nov 16, 2021

ouchadam Nov 16, 2021

bmarty Nov 16, 2021

ouchadam left a comment

Android12 #4433

Android12 #4433

Conversation

bmarty commented Nov 9, 2021 • edited Loading

github-actions bot commented Nov 9, 2021 • edited Loading

Unit Test Results

ouchadam Nov 16, 2021

Choose a reason for hiding this comment

bmarty Nov 16, 2021

Choose a reason for hiding this comment

ouchadam Nov 16, 2021 • edited Loading

Choose a reason for hiding this comment

bmarty Nov 16, 2021

Choose a reason for hiding this comment

ouchadam Nov 16, 2021

Choose a reason for hiding this comment

ouchadam Nov 16, 2021

Choose a reason for hiding this comment

ouchadam Nov 16, 2021

Choose a reason for hiding this comment

bmarty Nov 16, 2021

Choose a reason for hiding this comment

ouchadam left a comment

Choose a reason for hiding this comment

bmarty commented Nov 9, 2021 •

edited

Loading

github-actions bot commented Nov 9, 2021 •

edited

Loading

ouchadam Nov 16, 2021 •

edited

Loading