Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Direct message not initiated after telling the app to do so via the space member list #4319

Closed
aWeinzierl opened this issue Oct 22, 2021 · 6 comments · Fixed by #5292
Closed

Direct message not initiated after telling the app to do so via the space member list #4319

aWeinzierl opened this issue Oct 22, 2021 · 6 comments · Fixed by #5292
Assignees
@mnaturel
Labels
A-Spaces Spaces, groups, communities O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Ready This issue is ready for development Z-WTF WTF moment: High Impact, Low Effort

Comments

@aWeinzierl
Copy link
Contributor

Steps to reproduce

  1. open a space
  2. use context menu of different space (not sure if the Space must be different)
  3. list members
  4. tap on a member (you don't have a chat with <- maybe not required either)
  5. tap direct message
  6. see Space menu

Intended result and actual result

What did you expect?

See DM opening

What happened instead?

See Space menu

20211022_161842.mp4

Your phone model

Fairphone 3+

Operating system version

Android 10

Application version and app store

Element version 1.3.4 [40103042] (G-b4036) from GitHub

Homeserver

matrix.org

Will you send logs?

No
@aWeinzierl aWeinzierl added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Oct 22, 2021
@kittykat
Copy link
Contributor

What it opens there is the user info panel rather than DM (DM is first option if you're not a space admin)

@kittykat kittykat added A-Spaces Spaces, groups, communities X-Needs-Product Issue needs input from Product team labels Oct 22, 2021
@ouchadam ouchadam added O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist labels Oct 25, 2021
@ouchadam
Copy link
Contributor

has needs-product been added because we're unsure about opening a dm?

@kittykat kittykat added S-Major Severely degrades major functionality or product features, with no satisfactory workaround and removed S-Minor Impairs non-critical functionality or suitable workarounds exist X-Needs-Product Issue needs input from Product team labels Jan 14, 2022
@kittykat
Copy link
Contributor

has needs-product been added because we're unsure about opening a dm?

I'm not sure why I added Needs-Product. I think this should just be fixed, it can get very frustrating!

@ouchadam ouchadam added the Z-WTF WTF moment: High Impact, Low Effort label Jan 14, 2022
@daniellekirkwood
Copy link
Contributor

daniellekirkwood commented Feb 2, 2022 •
edited
Loading

Agreed. Although @kittykat Kat speaks for the Needs-Product label.

I will mark this issue as "Ready". The issue should be fixed and the Direct Message button should take users to create a DM

@daniellekirkwood daniellekirkwood added the Z-Ready This issue is ready for development label Feb 2, 2022
@mnaturel mnaturel self-assigned this Feb 21, 2022
@mnaturel mnaturel mentioned this issue Feb 22, 2022
Merged
15 tasks
@mnaturel
Copy link
Contributor

Hello @daniellekirkwood, as suggested by @bmarty in this comment, I wanted to confirm the changes I have done in the navigation behavior. In the following GIFs you can see the before/after. The difference is we do not close the member profile screen anymore which has impact on back navigation.

Before (From room timeline)

After (From room timeline)

After (From list members)

bmarty added a commit that referenced this issue Feb 28, 2022
@bmarty
Merge pull request #5292 from vector-im/feature/mna/4319-dm-space-mem…
781a477 
…bers-list

#4319: Fix DM navigation in member profile screen
@bmarty
Copy link
Member

bmarty commented Feb 28, 2022

Fixed in 1.4.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnaturel mnaturel

Labels
A-Spaces Spaces, groups, communities O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Ready This issue is ready for development Z-WTF WTF moment: High Impact, Low Effort
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#4319: Fix DM navigation in member profile screen element-hq/element-android
6 participants
@kittykat @ouchadam @bmarty @aWeinzierl @mnaturel @daniellekirkwood