Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incr sync investigation #4046

Merged
merged 14 commits into from
Sep 23, 2021
Merged

Incr sync investigation #4046

merged 14 commits into from
Sep 23, 2021

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Sep 20, 2021

This PR add debug info on room list and on room detail screen, if and only if developer mode and new option "show de bug info on screen" is on:

image

Displayed info are:

  • state of the sync thread
  • state of the sync request
  • number of PUSH received

Also this PR improves the log related to those parts of the code, so rageshakes will be more valuable

I used JetPack DataStore to store the number of received Push.

@bmarty bmarty requested a review from ganfra September 20, 2021 15:19
@github-actions
Copy link

github-actions bot commented Sep 20, 2021

Unit Test Results

  34 files  ±0    34 suites  ±0   21s ⏱️ ±0s
  73 tests ±0    73 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
180 runs  ±0  180 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit b52f2b0. ± Comparison against base commit b52f2b0.

♻️ This comment has been updated with latest results.

@bmarty
Copy link
Member Author

bmarty commented Sep 20, 2021

image

???

Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing that, will help

@bmarty bmarty force-pushed the feature/bma/incr_sync_investigation branch from f6295b1 to e27fa5d Compare September 23, 2021 11:55
@bmarty bmarty enabled auto-merge September 23, 2021 11:58
@bmarty bmarty merged commit b52f2b0 into develop Sep 23, 2021
@bmarty bmarty deleted the feature/bma/incr_sync_investigation branch September 23, 2021 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants