Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jitsi: introduces ConferenceEvent #4014

Merged
merged 2 commits into from
Sep 17, 2021
Merged

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Sep 15, 2021

This is just a small wrapper around Jitsi BroadcastEvent to avoid using this directly Fragment/Activity so we can get rid of Jitsi dependencies more easily.

@ganfra ganfra requested a review from bmarty September 15, 2021 09:03
@github-actions
Copy link

github-actions bot commented Sep 15, 2021

Unit Test Results

  34 files  ±0    34 suites  ±0   23s ⏱️ ±0s
  73 tests ±0    73 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
180 runs  ±0  180 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit f418683. ± Comparison against base commit f418683.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@Florian14 Florian14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, thanks for these changes!

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you add a file for the changelog please?

@ganfra
Copy link
Member Author

ganfra commented Sep 17, 2021

LGTM, can you add a file for the changelog please?

Done

@bmarty bmarty merged commit f418683 into develop Sep 17, 2021
@bmarty bmarty deleted the feature/fga/hide_jitsi_event branch September 17, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants