Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expired account error code #3900

Merged
merged 3 commits into from
Aug 27, 2021
Merged

Conversation

Florian14
Copy link
Contributor

For synapse instances which have activated and configured the email account validity module, an error code (ORG_MATRIX_EXPIRED_ACCOUNT) is triggered for any request authenticated by the user's access token which is expired.
This PR only add the error code in the matrix SDK but does not handle it for now in the client side.

More documentation can be found in the dedicated Synapse plugin module repository: https://github.com/matrix-org/synapse-email-account-validity

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one remark, else LGTM!

@@ -189,5 +189,8 @@ data class MatrixError(

// Possible value for "limit_type"
const val LIMIT_TYPE_MAU = "monthly_active_user"

/** The user account has expired. It has to be renewed by clicking on an email or by sending a renewal token. */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add
More documentation can be found in the dedicated Synapse plugin module repository: https://github.com/matrix-org/synapse-email-account-validity here too? I'like to have some link to the doc and not only in the PR description.

Thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

For synapse instances which have activated and configured the email account validity module, an error code (ORG_MATRIX_EXPIRED_ACCOUNT) is triggered for any request authenticated by the user's access token which is expired.
This change only add the error code in the matrix SDK but does not handle it for now in the client side.

More documentation can be found in the dedicated Synapse plugin module repository: https://github.com/matrix-org/synapse-email-account-validity
@Florian14 Florian14 force-pushed the feature/fre/expired_account_error branch from dfb2b0c to 7714cc4 Compare August 27, 2021 12:33
@Florian14 Florian14 requested a review from bmarty August 27, 2021 12:35
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@bmarty bmarty enabled auto-merge August 27, 2021 12:54
@bmarty bmarty merged commit e78434d into develop Aug 27, 2021
@bmarty bmarty deleted the feature/fre/expired_account_error branch August 27, 2021 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants