Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev tools are missing a button to submit send custom event and sent state event #3674

Closed
JanZerebecki opened this issue Jul 14, 2021 · 1 comment · Fixed by #4403
Closed

dev tools are missing a button to submit send custom event and sent state event #3674

JanZerebecki opened this issue Jul 14, 2021 · 1 comment · Fixed by #4403
Assignees
@ouchadam
Labels
A-devtools O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@JanZerebecki
Copy link

Describe the bug

The dev tools are missing a button to submit in the option for send custom event and sent state event.

To Reproduce

Steps to reproduce the behavior:

  1. Go to a rooms settings
  2. Click on 'Dev Tools'
  3. Click on 'Send Custom Event' or 'Send State Event'
  4. See no way to submit/send

Expected behavior

There should be a button 'Send'.

Smartphone (please complete the following information):

  • Device: [e.g. Samsung S6]
  • OS: [e.g. Android 6.0]

Additional context

  • App version and store 1.1.12 - F-Droid
@bmarty
Copy link
Member

bmarty commented Oct 26, 2021

The send action is a menu item at top right.
In dark theme:
image

But in Light theme:
image

So this is an issue about tinting the MenuItem icon.

@bmarty bmarty added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Oct 26, 2021
@bmarty bmarty added O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist A-devtools labels Oct 26, 2021
@ouchadam ouchadam self-assigned this Nov 3, 2021
@ouchadam ouchadam mentioned this issue Nov 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ouchadam ouchadam

Labels
A-devtools O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing missing dev tools light mode send button element-hq/element-android
3 participants
@ouchadam @bmarty @JanZerebecki