Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not notify about m.room.redaction #1491

Closed
Dragnucs opened this issue Jun 16, 2020 · 2 comments · Fixed by #4286
Closed

Do not notify about m.room.redaction #1491

Dragnucs opened this issue Jun 16, 2020 · 2 comments · Fixed by #4286
Assignees
@ouchadam
Labels
A-Notifications O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@Dragnucs
Copy link

If someone redacts a message from a room I have notifications on for, RiotX send a notification with the sole "m.room.redaction" text.

If I "see" the redaction from another client, on the laptop for example, RiotX will still keep the notification on while other are retracted.
@witchent
Copy link

Also, in encrypted rooms this message is being shown with a red shield, as it is obviously an non-encrypted message in an encrypted room. I guess this could lead to some confusion.

@ydnax ydnax mentioned this issue Feb 25, 2021
Closed
@Florian14 Florian14 mentioned this issue Jul 7, 2021
Closed
@Florian14 Florian14 added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Jul 7, 2021
@ouchadam ouchadam added A-Notifications O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Oct 21, 2021
@ouchadam ouchadam self-assigned this Oct 21, 2021
@ouchadam ouchadam added the S-Tolerable Low/no impact on users label Oct 21, 2021
@ouchadam ouchadam mentioned this issue Oct 21, 2021
Merged
@ouchadam ouchadam linked a pull request Oct 21, 2021 that will close this issue
Handle redacted events #4286
Merged
@ouchadam ouchadam mentioned this issue Oct 21, 2021
Merged
@ouchadam
Copy link
Contributor

fixed in 1.3.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ouchadam ouchadam

Labels
A-Notifications O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle redacted events element-hq/element-android
4 participants
@ouchadam @Dragnucs @Florian14 @witchent