Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compound tooltips are inaccessible #248

Closed
t3chguy opened this issue Oct 13, 2023 · 5 comments
Closed

Compound tooltips are inaccessible #248

t3chguy opened this issue Oct 13, 2023 · 5 comments
Assignees
Labels
A-Component Component implementation T-Defect

Comments

@t3chguy
Copy link
Member

t3chguy commented Oct 13, 2023

They do not open via keyboard navigation, which means users of keyboard navigation without a screen reader or similar utility have no access to the content in the tooltip

@germain-gg germain-gg added T-Defect A-Component Component implementation labels Oct 13, 2023
@nadonomy
Copy link
Contributor

For ref, documentation from Radix: https://www.radix-ui.com/primitives/docs/components/tooltip

Looks like it should support keyboard focus out of the box.

@t3chguy
Copy link
Member Author

t3chguy commented Nov 17, 2023

image

Their docs also imply we can't use their tooltips on interactive components which need those keys for themselves

@kerryarchibald kerryarchibald self-assigned this Nov 20, 2023
@kerryarchibald
Copy link
Contributor

Tooltips open on focus - according to this I think we meet criteria without having another keybinding.
When applied to non-interactive elements they are inaccessible - wrapping in a span is a suggested solution.

@t3chguy
Copy link
Member Author

t3chguy commented Nov 20, 2023

The wrapping in a span might cause an issue around keyboard focus though, if you activate a button which then gets disabled you wouldn't expect your focus to move, but as it would then get wrapped with a span your focus would be reset and as a screen reader user you would have to find the button again to know what the tooltip says.

@t3chguy
Copy link
Member Author

t3chguy commented Dec 20, 2023

I believe this is resolved

@t3chguy t3chguy closed this as completed Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Component Component implementation T-Defect
Projects
None yet
Development

No branches or pull requests

4 participants