Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for vet.domains #327

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

Add support for vet.domains #327

wants to merge 1 commit into from

Conversation

ifavo
Copy link
Contributor

@ifavo ifavo commented Feb 6, 2024

This is a draft pull request to get an opinion on the implementation and guidance on how to proceed.

Goal of this PR is to get a first basic implementation of vet.domains name resolution. Names can be entered in the recipient field and it will use the associated address. If an address has a primary name, its name will be shown as hint with the address input.

Here is a demo to visualize the change:
sync2

Due some unfamiliarity with Vue, my questions are:

  1. How can I best place the service for the name resolution with dependency to thor? I put it into the blockchain service but it feels like it should be its own service.
  2. Is the integration generally okay in the way it was started?

If this is comes to a successful merge, I want to extend the integration with further display of names in another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants