Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metrics] gitlab raw data #8

Closed
vchrombie opened this issue Jun 4, 2020 · 15 comments
Closed

[metrics] gitlab raw data #8

vchrombie opened this issue Jun 4, 2020 · 15 comments

Comments

@vchrombie
Copy link
Owner

vchrombie commented Jun 4, 2020

Opening this issue to discuss the possible metrics which can be extracted from the gitlab raw data for gitlabqm enricher.

@vchrombie vchrombie added this to the 🚴 Coding Period 1 milestone Jun 4, 2020
@vchrombie
Copy link
Owner Author

List of metrics which were proposed in the earlier meeting by @valeriocos

  • number of issues per day
  • number of comments per day
  • number of merges per day

@vchrombie
Copy link
Owner Author

vchrombie commented Jun 17, 2020

Hi @valeriocos

I was thinking of what all metrics can be defined from gitlab data.

number of issues per day

Can we make this metric into two with much more clear meaning like

  • number of issues opened per day
  • number of issues closed per day

We can use them in the QMs too.

WDYT?
@Polaris000 @inishchith @dlumbrer

@valeriocos
Copy link
Collaborator

+1, thanks

@Polaris000
Copy link
Collaborator

Sounds good!

@inishchith
Copy link

Sounds good @vchrombie

@dlumbrer
Copy link
Collaborator

+1 here as well :-) @vchrombie

@vchrombie
Copy link
Owner Author

I have implemented the issue related metrics.

  • number of issues opened per day

  • number of issues closed per day

I think we can do the same thing for merge requests too

number of merges per day

  • number of mrs opened in a day
  • number of mrs merged in a day
  • number of mrs closed in a day

@vchrombie
Copy link
Owner Author

number of comments per day

I left this at that time, but I'll complete it by the next PR.

@vchrombie
Copy link
Owner Author

vchrombie commented Jun 24, 2020

number of comments per day

do you think we need to consider the comments as two different entities like issue_comments and merge_comments?

I was thinking it would be better if we can keep them separate as we can specifically use numberIssueComments and numberMergeComments as metrics in the quality models if needed.

@valeriocos
Copy link
Collaborator

Yes, good idea! let's keep them separated for the moment.

@vchrombie
Copy link
Owner Author

I was thinking it would be better if we can keep them separate as we can specifically use numberIssueComments and numberMergeComments as metrics in the quality models if needed.

I have completed working on this. I will add them to the PR.

Also, I was going through the existing quality models, I saw one different metric in the Developer QM. It is the "number of issues attended". I think this has a different meaning than the number of comments. The numberIssueComments means the total number of comments across all issues on a particular day whereas the numberIssuesAttended would become the number of issues that have at least one comment on a particular date. This should be easy to implement.

Do you have any comments on this?

@valeriocos
Copy link
Collaborator

the numberIssuesAttended would become the number of issues that have at least one comment on a particular date. This should be easy to implement.

It should be the number of issues that have at least one comment, which is not written by the issue reporter, wdyt?

@vchrombie
Copy link
Owner Author

It should be the number of issues that have at least one comment, which is not written by the issue reporter, wdyt?

ah yes, that makes the definition more clear
thanks @valeriocos

@valeriocos
Copy link
Collaborator

you're welcome @vchrombie

@vchrombie
Copy link
Owner Author

planned metrics are implemented, so closing this issue
feel free to open if you have any more metric suggestions in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants