-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: tailwind css icon example #4969
Conversation
|
WalkthroughThe changes involve the addition of a new Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 eslint
playground/src/views/demos/features/icons/index.vueOops! Something went wrong! :( ESLint: 9.15.0 Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/node_modules/@vben/eslint-config/dist/index.mjs' imported from /eslint.config.mjs Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
playground/src/views/demos/features/icons/index.vue (1)
65-70
: Add ARIA labels for accessibilityThe icon spans lack accessibility attributes. Consider adding aria-labels to improve screen reader support.
- <span class="icon-[ant-design--alipay-circle-outlined]"></span> - <span class="icon-[ant-design--account-book-filled]"></span> - <span class="icon-[ant-design--container-outlined]"></span> - <span class="icon-[svg-spinners--wind-toy]"></span> - <span class="icon-[svg-spinners--blocks-wave]"></span> - <span class="icon-[line-md--compass-filled-loop]"></span> + <span class="icon-[ant-design--alipay-circle-outlined]" aria-label="Alipay" role="img"></span> + <span class="icon-[ant-design--account-book-filled]" aria-label="Account book" role="img"></span> + <span class="icon-[ant-design--container-outlined]" aria-label="Container" role="img"></span> + <span class="icon-[svg-spinners--wind-toy]" aria-label="Wind toy spinner" role="img"></span> + <span class="icon-[svg-spinners--blocks-wave]" aria-label="Blocks wave spinner" role="img"></span> + <span class="icon-[line-md--compass-filled-loop]" aria-label="Compass" role="img"></span>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
playground/src/views/demos/features/icons/index.vue
(1 hunks)
🔇 Additional comments (1)
playground/src/views/demos/features/icons/index.vue (1)
63-72
: Verify required icon sets are installed
The new card demonstrates Tailwind CSS icons from various sets (ant-design, svg-spinners, line-md). Let's verify these dependencies are properly configured.
Description
添加 Tailwind CSS 方式使用icon的例子
close #4968
Type of change
Please delete options that are not relevant.
pnpm-lock.yaml
unless you introduce a new test example.Checklist
pnpm run docs:dev
command.pnpm test
.feat:
,fix:
,perf:
,docs:
, orchore:
.Summary by CodeRabbit
New Features
Improvements