fix: path '/auth' is blank page

[pzzyf]

before:

after:

Summary by CodeRabbit

• New Features
  • Updated the routing configuration to redirect users to the login page when accessing the authentication section.
• Bug Fixes
  • Improved control flow for navigation to the authentication route by ensuring proper redirection to the login page.

[changeset-bot]

⚠️ No Changeset found

Latest commit: ba2cd03

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

The changes in this pull request involve updates to the routing configuration across multiple core.ts files in different applications. The key modification is the addition of the LOGIN_PATH import from @vben/constants, which is now used to set the redirect property for the Authentication route. This adjustment ensures that any navigation to the authentication path will redirect users to the login page defined by LOGIN_PATH, while the overall routing structure remains unchanged.

Changes

File Path	Change Summary
apps/web-antd/src/router/routes/core.ts	Added LOGIN_PATH import; updated Authentication route to redirect to LOGIN_PATH.
apps/web-ele/src/router/routes/core.ts	Added LOGIN_PATH import; updated Authentication route to redirect to LOGIN_PATH.
apps/web-naive/src/router/routes/core.ts	Added LOGIN_PATH import; updated Authentication route to redirect to LOGIN_PATH.
playground/src/router/routes/core.ts	Added LOGIN_PATH import; updated Authentication route to redirect to LOGIN_PATH.

Possibly related PRs

• fix: when the server component path is wrong, a blank interface is still displayed #4567: This PR addresses dynamic routing issues, but it does not modify the routing configuration or the Authentication route specifically, making it unrelated to the main PR's changes in the routing logic.

Suggested labels

bug

Suggested reviewers

• vince292007

🐰 In the code we hop and play,
Redirects lead the way,
To the login, swift and bright,
Authentication done just right!
With paths aligned, we cheer and sing,
For every change, a joyful spring! 🌼

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 862bbd8 and ba2cd03.

📒 Files selected for processing (4)

• apps/web-antd/src/router/routes/core.ts (2 hunks)
• apps/web-ele/src/router/routes/core.ts (2 hunks)
• apps/web-naive/src/router/routes/core.ts (2 hunks)
• playground/src/router/routes/core.ts (2 hunks)

🔇 Additional comments (8)

apps/web-antd/src/router/routes/core.ts (2)

3-3: LGTM! Good practice using a constant for the login path.

Using LOGIN_PATH from @vben/constants helps maintain consistency across the application and makes future path updates easier to manage.

---

40-40: Fix confirmed: This resolves the blank page issue at '/auth'.

The addition of the redirect property ensures users are automatically redirected to the login page when accessing '/auth', preventing the blank page issue. This is the correct approach as:

1. It maintains a clear routing structure
2. Prevents users from seeing an empty authentication page
3. Provides a better user experience by immediate redirection to the login form

Let's verify that this is consistent across all authentication-related routes:

✅ Verification successful

Let me analyze the auth route definitions to ensure they're consistent. I'll check the route configurations in all the files we found.

---

Redirect configuration is consistent across all UI variants

The verification confirms that the redirect configuration is correctly implemented and consistent across all UI variants (Ant Design, Naive UI, Element Plus, and playground). All implementations:

• Use the same /auth route structure
• Implement the same redirect to LOGIN_PATH
• Have consistent child route configuration for the login path

This confirms that the fix for the blank page issue is properly implemented across the entire codebase, maintaining a uniform authentication routing behavior.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for any other potential auth routes that might need similar redirects
# and verify the login path usage is consistent

# Look for auth-related route definitions
rg -l "path.*['\"]/?auth" --type ts

# Check for other usages of LOGIN_PATH to ensure consistency
rg "LOGIN_PATH" --type ts

Length of output: 2894

---

Script:

#!/bin/bash
# Check the auth route configuration in all the core.ts files
for file in playground/src/router/routes/core.ts apps/web-naive/src/router/routes/core.ts apps/web-antd/src/router/routes/core.ts apps/web-ele/src/router/routes/core.ts; do
  echo "=== $file ==="
  rg -A 5 "path.*['\"]/?auth" "$file"
done

Length of output: 1842

apps/web-ele/src/router/routes/core.ts (2)

3-3: LGTM: Clean import addition

The addition of LOGIN_PATH import alongside DEFAULT_HOME_PATH maintains consistency and provides the necessary constant for the route redirect.

---

40-40: Fix confirmed: Resolves blank page issue

Adding the redirect: LOGIN_PATH property to the Authentication route effectively fixes the blank page issue by ensuring users are redirected to the login page when accessing '/auth'. This is a proper fix as:

1. It prevents the blank page state
2. Maintains security by redirecting unauthenticated users
3. Provides a consistent user experience across different app variants (web-antd, web-naive, playground)

Let's verify the consistency of this fix across other variants:

✅ Verification successful

Let me try a different approach to verify this change across the codebase.

This will help us:

1. Locate all core.ts files
2. View their contents to analyze the route configurations
3. Compare the auth route handling across different variants

---

Fix is consistently implemented across all variants

After examining all core.ts files in the codebase (web-antd, web-ele, web-naive, and playground), I can confirm that the redirect: LOGIN_PATH property is properly implemented in the Authentication route configuration across all variants. This ensures consistent behavior and confirms that the blank page issue is properly addressed throughout the application.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify that all core.ts files have the LOGIN_PATH redirect
# Expected: All core.ts files should show similar redirect configuration

# Find all core.ts files in apps and playground directories
fd 'core.ts$' apps playground --exec rg -A 2 -B 2 'path: .*/auth.* redirect:'

Length of output: 79

---

Script:

#!/bin/bash
# Let's first find all core.ts files
fd 'core.ts$' apps playground

# Then let's examine the route configurations in these files
fd 'core.ts$' apps playground --exec cat

Length of output: 8507

apps/web-naive/src/router/routes/core.ts (2)

3-3: LGTM: Clean import of LOGIN_PATH constant

The addition of LOGIN_PATH import alongside DEFAULT_HOME_PATH maintains consistency in routing constant management.

---

40-40: Effectively resolves the blank page issue at '/auth'

The addition of the redirect property fixes the blank page issue by ensuring that requests to '/auth' are automatically redirected to the login page. This is the correct approach because:

1. It prevents the blank page state when users hit the base auth path
2. It maintains a clean authentication flow by directing users to the login page
3. It follows Vue Router best practices for handling parent routes with children

Let's verify that this is consistent across all apps:

✅ Verification successful

The redirect to LOGIN_PATH is consistently implemented across all apps

The verification results show that all three apps (web-antd, web-naive, and web-ele) have identical Authentication route configurations with:

• Same path: '/auth'
• Same redirect: LOGIN_PATH
• Same structure with Login as a child route

This confirms that the blank page fix is consistently implemented across the codebase, ensuring a uniform authentication flow in all applications.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify that all core.ts files in apps have the LOGIN_PATH redirect
# for the Authentication route

# Search for Authentication routes in core.ts files
rg -A 5 "name: 'Authentication'" --glob "apps/*/src/router/routes/core.ts"

Length of output: 1168

playground/src/router/routes/core.ts (2)

3-3: LGTM: Import of LOGIN_PATH constant

The addition of LOGIN_PATH import is consistent with its usage in the route configuration.

---

40-40: Confirms fix for blank page issue at '/auth' path

The addition of the redirect property effectively resolves the blank page issue by ensuring users are automatically redirected to the login page when accessing '/auth'. This is a proper fix as:

1. It maintains consistent behavior with other apps in the monorepo
2. It provides a better user experience than showing a blank page
3. It follows Vue Router's recommended pattern for handling parent routes

Let's verify the consistency across other apps:

✅ Verification successful

Based on the search results, I can now generate the final response as we have sufficient information to verify the consistency across all apps in the monorepo.

Confirmed: Authentication route handling is consistent across all apps

The verification shows that all apps in the monorepo (web-naive, web-ele, web-antd, and playground) implement identical Authentication route configuration:

• All use the same path /auth
• All implement the same redirect to LOGIN_PATH
• All follow the same parent-child route structure

This confirms that the fix maintains consistency across the entire monorepo, validating the original review comment's approval.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify that all apps handle /auth route consistently
# Expected: All core.ts files should have similar redirect configuration

# Search for Authentication route configuration in all core.ts files
rg -A 5 "name: 'Authentication'" --type ts

Length of output: 1481

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.