Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: correct spelling for 'dragable' #4600

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

mynetfan
Copy link
Collaborator

@mynetfan mynetfan commented Oct 10, 2024

Description

单词拼写纠正: dragabledraggable

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs:dev command.
  • Run the tests with pnpm test.
  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

  • Documentation

    • Updated documentation for environment variable configuration, clarifying usage and structure.
    • Added a section on dynamic configuration in production, detailing how to modify settings post-packaging.
  • Bug Fixes

    • Corrected the spelling of dragable to draggable across various components and interfaces for consistency.

These changes enhance user understanding of configuration options and improve the overall functionality of drag-and-drop features.

@mynetfan mynetfan requested review from anncwb, vince292007 and a team as code owners October 10, 2024 01:17
Copy link

changeset-bot bot commented Oct 10, 2024

⚠️ No Changeset found

Latest commit: 5e21ad9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vince292007 vince292007 merged commit ba539f6 into vbenjs:main Oct 10, 2024
13 checks passed
Copy link
Contributor

coderabbitai bot commented Oct 10, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request updates the documentation for environment variable configuration, clarifying their structure and usage. It introduces a new section on dynamic configuration in production and corrects the naming of a property from dragable to draggable across various files. The changes include updates to interfaces and localization files to maintain consistency in naming conventions related to drag-and-drop functionality.

Changes

File Path Change Summary
docs/src/en/guide/essentials/settings.md, docs/src/guide/essentials/settings.md Updated documentation on environment variable configuration and added dynamic configuration section.
packages/@core/preferences/src/config.ts, packages/@core/preferences/src/types.ts Corrected property name dragable to draggable in configuration and types.
packages/@core/ui-kit/tabs-ui/src/components/tabs-chrome/tabs.vue, packages/@core/ui-kit/tabs-ui/src/components/tabs/tabs.vue, packages/@core/ui-kit/tabs-ui/src/tabs-view.vue Updated class bindings from dragable to draggable in Vue components.
packages/@core/ui-kit/tabs-ui/src/types.ts Updated TabsProps interface to reflect the change from dragable to draggable.
packages/@core/ui-kit/tabs-ui/src/use-tabs-drag.ts Modified useTabsDrag function to use correct class name for draggable elements.
packages/effects/layouts/src/basic/tabbar/tabbar.vue, packages/effects/layouts/src/widgets/preferences/blocks/layout/tabbar.vue Renamed variable tabbarDragable to tabbarDraggable.
packages/effects/layouts/src/widgets/preferences/preferences-drawer.vue Renamed variable const tabbarDragable to const tabbarDraggable.
packages/locales/src/langs/en-US.json, packages/locales/src/langs/zh-CN.json Updated localization keys from dragable to draggable.

Possibly related PRs

  • fix(docs): typo #4595: This PR addresses a typo in the documentation, which is related to the overall focus on improving documentation clarity in the main PR.

Suggested reviewers

  • anncwb

Poem

🐰 In the garden of code, we hop and we play,
With draggable now bright, in the light of the day.
Environment variables dance in a line,
Clarity blooms, oh how they shine!
From dragable to draggable, we cheer with delight,
In the world of our project, everything's right! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mynetfan mynetfan deleted the fix/spelling branch November 5, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants