-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: the translation is incorrect when switching languages for the first time #4146
Conversation
|
WalkthroughThe recent changes enhance the internationalization (i18n) capabilities of a Vue.js application by introducing a new setup function, Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- packages/locales/src/i18n.ts (4 hunks)
- packages/locales/src/index.ts (1 hunks)
Additional comments not posted (5)
packages/locales/src/index.ts (1)
6-10
: Re-exporting types enhances modularity.Re-exporting types from
./typing
improves modularity and type management across the application.packages/locales/src/i18n.ts (4)
3-8
: Type imports support new setup requirements.The imported types are necessary for the new
setupI18n
function and align with the updated structure.
26-27
:loadMessages
initialization is flexible.The
loadMessages
variable is initialized to hold a function reference, allowing for flexible message loading.
55-70
:setupI18n
function enhances flexibility and initialization.The
setupI18n
function correctly initializes i18n, integrates with the app, and handles missing translations with a warning system.
Line range hint
76-93
:
loadLocaleMessages
function improves locale handling.The function effectively loads and merges locale messages, aligning with the new i18n setup logic.
closes #4138
Description
Type of change
Please delete options that are not relevant.
pnpm-lock.yaml
unless you introduce a new test example.Checklist
pnpm run docs:dev
command.pnpm test
.feat:
,fix:
,perf:
,docs:
, orchore:
.Summary by CodeRabbit
New Features
setupI18n
function for improved internationalization setup.Changes
loadI18nMessages
toloadLocaleMessages
for clarity.setupI18n
function by removing unnecessary logic.Documentation