Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds row support to uniforms-material RadioField #834

Merged
merged 2 commits into from
Dec 5, 2020

Conversation

asibilia
Copy link
Contributor

@asibilia asibilia commented Dec 3, 2020

Since RadioField is using Material's RadioGroup this change would allow users to specify the row property for the group (changing the orientation from vertical to horizontal).

From Material's RadioGroup API:

To lay out the buttons horizontally, set the row prop: .

@asibilia asibilia requested a review from radekmie as a code owner December 3, 2020 23:49
@asibilia asibilia changed the title Adds row support to uniforms-material RadioField radio field Adds row support to uniforms-material RadioField Dec 3, 2020
@codecov
Copy link

codecov bot commented Dec 3, 2020

Codecov Report

Merging #834 (d752e7b) into master (27681eb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #834   +/-   ##
=======================================
  Coverage   97.54%   97.54%           
=======================================
  Files         175      175           
  Lines        3419     3420    +1     
  Branches      659      658    -1     
=======================================
+ Hits         3335     3336    +1     
  Misses          8        8           
  Partials       76       76           
Impacted Files Coverage Δ
packages/uniforms-material/src/RadioField.tsx 89.28% <100.00%> (+0.39%) ⬆️
packages/uniforms/src/BaseForm.tsx 96.42% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27681eb...d752e7b. Read the comment docs.

Copy link
Contributor

@radekmie radekmie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @asibilia! I've added two minor requests.

packages/uniforms-material/src/RadioField.tsx Outdated Show resolved Hide resolved
packages/uniforms-material/src/RadioField.tsx Outdated Show resolved Hide resolved
@radekmie radekmie added the Type: Feature New features and feature requests label Dec 4, 2020
@asibilia asibilia requested a review from radekmie December 4, 2020 14:32
@radekmie radekmie merged commit 025598b into vazco:master Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New features and feature requests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants