Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using deprecated "raised" variant, use "contained" instead #498

Merged
merged 2 commits into from
Jan 4, 2019

Conversation

Floriferous
Copy link
Contributor

Material-ui has started throwing warnings when using the old raised variant.

@Floriferous Floriferous requested a review from radekmie as a code owner January 4, 2019 13:41
@codecov
Copy link

codecov bot commented Jan 4, 2019

Codecov Report

Merging #498 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #498   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files         157    158    +1     
  Lines        1474   1477    +3     
=====================================
+ Hits         1474   1477    +3
Impacted Files Coverage Δ
packages/uniforms-material/src/BoolField.js 100% <100%> (ø) ⬆️
packages/uniforms-material/src/ErrorField.js 100% <100%> (ø) ⬆️
packages/uniforms-material/src/DateField.js 100% <100%> (ø) ⬆️
packages/uniforms-material/src/NestField.js 100% <100%> (ø) ⬆️
packages/uniforms-material/src/ListAddField.js 100% <100%> (ø) ⬆️
packages/uniforms-material/src/SelectField.js 100% <100%> (ø) ⬆️
packages/uniforms-material/src/RadioField.js 100% <100%> (ø) ⬆️
packages/uniforms-material/src/SubmitField.js 100% <100%> (ø) ⬆️
packages/uniforms-material/src/wrapField.js 100% <100%> (ø)
packages/uniforms-material/src/ErrorsField.js 100% <100%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 827f14f...3c26d03. Read the comment docs.

@radekmie radekmie added the Type: Feature New features and feature requests label Jan 4, 2019
@radekmie
Copy link
Contributor

radekmie commented Jan 4, 2019

Hi @Floriferous. Is there a way to actually check the version of @material-ui/core? The contained variant was introduced in 1.2.0, so a dependency range have to be changed.

@Floriferous
Copy link
Contributor Author

Not sure how to do that? But since 1.2.0 was released 7 months ago, can't you put a hard constraint on 1.2.0+ today? There's no hard upgrades since this package already uses 1.0, so I don't think there's a good reason for people not to follow material-ui's updates ?

@radekmie
Copy link
Contributor

radekmie commented Jan 4, 2019

OK then, let's change the dependency version to start from 1.2.0.

Required to use the new `contained` variant of `Button`
@radekmie radekmie merged commit db528d5 into vazco:master Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New features and feature requests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants