Fix extracting the type from GraphQLNonNull in getProps

[jgoux]

The internal type stored in GraphQLNonNull was never extracted as the whole field needs to be passed according to extractFromNonNull definition.

[jgoux]

I think we have to decide either extractFromNonNull returns a field or the underlying type only.

This still not pass :

if (
      fieldType instanceof graphql.GraphQLScalarType &&
      fieldType.name === 'Float'
    ) {
      ready.decimal = true
    }

Because to refer to the internal type, we need to do fieldType.type instanceof graphql.GraphQLScalarType

[radekmie]

It should return the underlying type, so GraphQLScalarType and friends. Can we start with adding the tests which should fail in the current implementation? Also, I don't clearly understand, when the current code is not working - could you provide an example?

[jgoux]

I added the failing case by making the decimal a non nullable.

Now we can see that we never pass into :

if (fieldType instanceof graphql.GraphQLScalarType && fieldType.name === 'Float') {
    ready.decimal = true;
}

As you say, extractFromNonNull should return the underlying type so I think the implementation should be :

const extractFromNonNull = type => type && type instanceof graphql.GraphQLNonNull ? type.ofType : type;

[radekmie]

Huh, I'm not sure anymore. I'm not really sure about what the implementation should be, but I think that two things are important here: one, we need to pass fieldType in the same manner, two, cases like decimal should be working correctly.

I'll get to it later today.

[radekmie]

OK, so:

const fieldType = extractFromNonNull(field).type;

Seems to work. Can you check if it works for you too?

[jgoux]

It works! 👍

[codecov]

Codecov Report

Merging #460 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #460   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files         157    157           
  Lines        1404   1404           
=====================================
  Hits         1404   1404

Impacted Files	Coverage Δ
packages/uniforms/src/GraphQLBridge.js	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3664d63...9ac44d0. Read the comment docs.