Section to div #172
Merged
Section to div #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, I will merge it after #170. |
|
@zeroasterisk, there are conflicts, due to #170 - I'll merge it after you'll solve them. |
|
@zeroasterisk will you have some time to do this? |
> Do not use the <section> element as a generic container; this is what <div> is for, especially when the sectioning is only for styling purposes. A rule of thumb is that a section should logically appear in the outline of a document. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/section
zeroasterisk
force-pushed
the
section-to-div
branch
from
fd6d2b0 to
099f503
Compare
|
Ok - I re-ran this |
radekmie
approved these changes
Jan 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched from section --> div in ALL components
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/section