From e57a505d8ce893c62417dd04caed364cd3d0893a Mon Sep 17 00:00:00 2001 From: Fekete Mihai Date: Wed, 11 May 2016 09:46:59 +0300 Subject: [PATCH] [REF] hr_employee_firstname: Split names at module install to get the value not the key of dict (#215) * Update split names at module install to get the value not the key of the dict. * Add test for checking right values in firstname, lastname after install --- hr_employee_firstname/models/hr_employee.py | 6 +++--- .../tests/test_hr_employee_firstname.py | 9 +++++++++ 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/hr_employee_firstname/models/hr_employee.py b/hr_employee_firstname/models/hr_employee.py index cbb5b5f22c98..e7022e28c29f 100644 --- a/hr_employee_firstname/models/hr_employee.py +++ b/hr_employee_firstname/models/hr_employee.py @@ -45,10 +45,10 @@ def _update_employee_names(self): ('firstname', '=', ' '), ('lastname', '=', ' ')]) for ee in employees: - lastname, firstname = self.split_name(ee.name) + split_name = self.split_name(ee.name) ee.write({ - 'firstname': firstname, - 'lastname': lastname, + 'firstname': split_name['firstname'], + 'lastname': split_name['lastname'], }) @api.model diff --git a/hr_employee_firstname/tests/test_hr_employee_firstname.py b/hr_employee_firstname/tests/test_hr_employee_firstname.py index dfbd92edd476..fb49f1042005 100644 --- a/hr_employee_firstname/tests/test_hr_employee_firstname.py +++ b/hr_employee_firstname/tests/test_hr_employee_firstname.py @@ -19,6 +19,7 @@ # ############################################################################## +import openerp.tests from openerp.tests.common import TransactionCase @@ -109,3 +110,11 @@ def test_change_firstname_and_lastname(self): self.employee1_id.refresh() self.assertEqual(self.employee1_id.name, 'Carnaud Jean-Pierre') + + @openerp.tests.common.at_install(False) + @openerp.tests.common.post_install(True) + def test_update_name_post_install(self): + self.empl_demo = self.env.ref('hr.employee_fp') + + self.assertEqual(self.empl_demo.firstname, 'Parker') + self.assertEqual(self.empl_demo.lastname, 'Pieter')