Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional on/off values for CLI flags #341

Closed
ThijsFeryn opened this issue Sep 9, 2020 · 2 comments
Closed

Optional on/off values for CLI flags #341

ThijsFeryn opened this issue Sep 9, 2020 · 2 comments
Assignees

Comments

@ThijsFeryn
Copy link

The current implementation of Hitch doesn't allow CLI flags like --write-proxy-v2 to accept on/off values.

It would be nice to set the following:

--write-proxy-v2=off

Although you could consider omitting this CLI flag from the command to disable this feature, this doesn't work if the feature was enabled in the hitch.conf file.

This shouldn't be a backwards compatibility break, because the original value --write-proxy-v2 will still work.

The desired outcome is to be able to set both on and off for any CLI option that doesn't yet accept values:

  • --tls
  • --ssl
  • --client
  • --quiet
  • --syslog
  • --daemon
  • --write-ip
  • --write-proxy-v1
  • --write-proxy-v2
  • --write-proxy
  • --write-proxy-proxy
  • --sni-nomatch-abort
@gquintard
Copy link
Contributor

agreed, I've been bit by that one, notably for the daemon option

@daghf daghf self-assigned this Sep 14, 2020
@daghf
Copy link
Member

daghf commented Oct 13, 2020

I've added b897a4b which should take care of this.

For --tls/--ssl I'll deal with that separate as part of the fix for #340.

@daghf daghf closed this as completed Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants