Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dual RSA+EC certificates #169

Open
alexshpilkin opened this issue Feb 26, 2017 · 8 comments
Open

Support dual RSA+EC certificates #169

alexshpilkin opened this issue Feb 26, 2017 · 8 comments

Comments

@alexshpilkin
Copy link

alexshpilkin commented Feb 26, 2017

As far as I can tell from the code, Hitch currently selects the certificate to present based only on the name provided by SNI (if any). If one wants to use EC certificates (supported after #116) and support legacy RSA-only clients, it is necessary to keep RSA and EC certificates for the same domain simultaneously and choose also depending on the negotiation parameters. For example, this question on ServerFault discusses configuring this in Apache ≥2.4.8: https://serverfault.com/q/665296/.

@alexshpilkin alexshpilkin changed the title Support dual ECC+RSA certificates Support dual RSA+EC certificates Feb 26, 2017
@HLeithner
Copy link

It would be really great to get this into hitch, but it seams hitch doesn't get much love from varnish team...

@zi0r
Copy link
Contributor

zi0r commented Apr 12, 2019

Is this something that is on the radar? Am running into the same issue and trying to decide on a path to resolution.

@gquintard
Copy link
Contributor

Hi,

This is definitely on the roadmap, and is just limited by the OpenSSL upgrade I believe.

@zi0r
Copy link
Contributor

zi0r commented May 8, 2019

Is this something the hitch team would like to develop internally? Would you be willing to accept an outside patch? I've access to some development resources that I might be able to offer.

@gquintard
Copy link
Contributor

@zi0r, we are definitely open to contributions! Please have a go at it if you can

@zi0r
Copy link
Contributor

zi0r commented May 8, 2019

If you have any requests/thoughts on a rough implementation strategedy, I'd love to be able to hear what you are thinking. It will probably enable us to more rapidly reach something we're both happy with!

@gquintard
Copy link
Contributor

let me check with my colleagues if they have any view on that. On the user-side, from what I get, there's nothing to configure, apart from specifying the right certificates, then Hitch should just do the right thing™.

We'll obviously want tests covering this, but we can work on that later on

@gquintard
Copy link
Contributor

Hello @zi0r, we talked about this, and we don't have feedback at the moment other than "keep it clean and simple" :-)

I'm on the varnish IRC channels if you want to discuss this in a more synchronous manner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants