Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale is no longer propagated to the server #88

Open
bramthijssen opened this issue Nov 2, 2022 · 2 comments
Open

Scale is no longer propagated to the server #88

bramthijssen opened this issue Nov 2, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@bramthijssen
Copy link

It looks like jobs submitted with a --scale command are not actually being scaled anymore. This worked before, but not anymore. I believe this is because in the predict controller in the server, the argument "dataRescale" has been renamed to "scale", but this was not updated in the kiosk-client?

@bramthijssen
Copy link
Author

Yeah; if I change the predict job data, at job.py:266 from

'dataRescale': self.data_scale,

to the following

'jobForm': {"scale": self.data_scale},

the scaling works again. I'm not sure how to create a pull request; and perhaps also some other variables need to be updated as well?

@msschwartz21
Copy link
Member

Thank you for posting about this issue and the solution that you found! We would appreciate a pull request if you are interested in opening one. Here is a description of the fork and pull request workflow published by github https://docs.github.com/en/get-started/quickstart/contributing-to-projects.

@msschwartz21 msschwartz21 added the bug Something isn't working label Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants