Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal case status cannot be updated with autodeployment #24

Open
erik-ritense opened this issue Jan 2, 2025 · 2 comments
Open

Internal case status cannot be updated with autodeployment #24

erik-ritense opened this issue Jan 2, 2025 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@erik-ritense
Copy link

Expected behavior

When creating a new changeset for internal-case-status auto-deployment, existing entries can be part of the auto-deployment file. Unchanged entries should be ignored, and changed entries should be updated.

Current behavior

At the moment it is not possible to have an auto-deployment changeset the includes an existing internal case status. When doing so an InternalCaseStatusAlreadyExistsException is thrown.
The result of this behaviour:

  • The application will not start when an existing internal case status is part of the new change set.
  • An internal case status can never be updated.
  • Adding a new status can only be achieved by creating a new changeset without the existing entries.

Possible solution (optional)

Instead of raising an exception and abort the startup of the application, do an update of the existing entry.

Steps to reproduce

Provide an unambiguous set of steps to reproduce this bug.
Include code to reproduce, if relevant

  1. Start up Valtimo from source.
  2. Create a "bezwaar" dossier
  3. Observe that the tag for internal case status "Aanvraag ontvangen" is blue.
  4. Edit the resources/config/internal-case-status/bezwaar.internal-case-status.json and change BLUE to GREEN
  5. Start the application again.
@erik-ritense erik-ritense added the bug Something isn't working label Jan 2, 2025
@Frits-Ritense
Copy link

@ThomasMinkeRitense This also prevents cases that have an internalStatus to update environments via export/import.

@erik-ritense
Copy link
Author

@Frits-Ritense / @ThomasMinkeRitense
PR for adding the update functinality has been submitted:
valtimo-platform/valtimo-backend-libraries#1717

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants