New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`withMinimalLevel` does not work properly with `AsyncLogger` #460

Open

iRevive opened this issue Jun 19, 2022 · 0 comments · May be fixed by #461

Contributor

iRevive commented Jun 19, 2022

The following example prints nothing, unfortunately:

io.odin.consoleLogger[IO](minLevel = Level.Info).withAsync()
  .use { logger =>
    logger.withMinimalLevel(Level.Debug).debug("debug message")
  }

Scastie https://scastie.scala-lang.org/NI4CRSYwTpWyCVkfaFKWcw

withMinimalLevel creates a copy of the logger, but the background consumer references the original one https://github.com/valskalla/odin/blob/master/core/src/main/scala/io/odin/loggers/AsyncLogger.scala#L65.

The text was updated successfully, but these errors were encountered:

iRevive linked a pull request

that will close this issue

AsyncLogger: enqueue logging operation instead of a log message #461

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment