Test/models #317
Open
Test/models #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adamantios
requested changes
Aug 26, 2024
Comment on lines
+91
to
+95
| assert loader == ( | ||
| {"entry_point": "entry_point.py", "callable": "dummy_callable"}, | ||
| "dummy_function()", | ||
| "dummy_callable", | ||
| ) |
There was a problem hiding this comment.
Ideally, introduce this as an attribute above, e.g., expected_loader, instead of hardcoding here.
Comment on lines
+42
to
+43
| self.liquidity_info.l0_end = None | ||
| self.liquidity_info.l0_end = None |
There was a problem hiding this comment.
Suggested change
| self.liquidity_info.l0_end = None | |
| self.liquidity_info.l0_end = None | |
| self.liquidity_info.l0_end = None |
There was a problem hiding this comment.
I think that the BenchmarkingMockData is not tested (it has a simple property).
Comment on lines
+63
to
+65
| question = Question(id=id, data="dummy_data") | ||
|
|
||
| question.__post_init__() |
There was a problem hiding this comment.
The post init is automatically called. I would suggest that you check whether its result is the expected one, i.e., if the given id is a string, check that it is bytes after initialization.
| condition = Condition( | ||
| id="0x00000000000000001234567890abcdef", outcomeSlotCount=2 | ||
| ) | ||
| condition.__post_init__() |
There was a problem hiding this comment.
Same comment re post init as below.
| ), | ||
| templateId=1, | ||
| ) | ||
| fpmm.__post_init__() |
| transactionHash="0x5b6a3f8eaa6c8a5c3b123d456e7890abcdef1234567890abcdef1234567890ab", | ||
| ) | ||
|
|
||
| trade.__post_init__() |
Comment on lines
+45
to
+118
| DUMMY_DECISION_MAKER_PARAMS = { | ||
| "sample_bets_closing_days": 1, | ||
| "trading_strategy": "test", | ||
| "use_fallback_strategy": True, | ||
| "tools_accuracy_hash": "test", | ||
| "bet_threshold": 1, | ||
| "blacklisting_duration": 1, | ||
| "prompt_template": "@{yes}@{no}@{question}", | ||
| "dust_threshold": 1, | ||
| "conditional_tokens_address": "0x123", | ||
| "realitio_proxy_address": "0x456", | ||
| "realitio_address": "0x789", | ||
| "event_filtering_batch_size": 1, | ||
| "reduce_factor": 1.1, | ||
| "minimum_batch_size": 1, | ||
| "max_filtering_retries": 1, | ||
| "redeeming_batch_size": 1, | ||
| "redeem_round_timeout": 1.1, | ||
| "slippage": 0.05, | ||
| "policy_epsilon": 0.1, | ||
| "agent_registry_address": "0xabc", | ||
| "irrelevant_tools": [], | ||
| "tool_punishment_multiplier": 1, | ||
| "contract_timeout": 2.0, | ||
| "file_hash_to_strategies_json": [ | ||
| ['{"k1": "key2"}', '{"b1": "b2"}'], | ||
| ['{"v1": "v2"}', '{"b1": "b2"}'], | ||
| ], | ||
| "strategies_kwargs": [ | ||
| ['{"k1": "key2"}', '{"b1": "b2"}'], | ||
| ['{"v1": "v2"}', '{"b1": "b2"}'], | ||
| ], | ||
| "use_subgraph_for_redeeming": True, | ||
| "use_nevermined": False, | ||
| "rpc_sleep_time": 2, | ||
| "mech_to_subscription_params": [ | ||
| ['{"k1": "key2"}', '{"b1": "b2"}'], | ||
| ['{"v1": "v2"}', '{"b1": "b2"}'], | ||
| ], | ||
| "service_endpoint": "http://example.com", | ||
| "store_path": str(PACKAGE_DIR), | ||
| } | ||
|
|
||
| DUMMY_MECH_INTERACT_PARAMS = { | ||
| "multisend_address": "0x1234567890abcdef1234567890abcdef12345678", | ||
| "multisend_batch_size": 100, | ||
| "mech_contract_address": "0xabcdef1234567890abcdef1234567890abcdef12", | ||
| "mech_request_price": 10, | ||
| "ipfs_address": "https://ipfs.example.com", | ||
| "mech_chain_id": "gnosis", | ||
| "mech_wrapped_native_token_address": "0x9876543210abcdef9876543210abcdef98765432", | ||
| "mech_interaction_sleep_time": 5, | ||
| } | ||
|
|
||
| DUMMY_TERMINATION_PARAMS = {"termination_sleep": 1, "termination_from_block": 1} | ||
|
|
||
| DUMMY_TRANSACTION_PARAMS = { | ||
| "init_fallback_gas": 1, | ||
| "keeper_allowed_retries": 1, | ||
| "validate_timeout": 300, | ||
| "finalize_timeout": 1.1, | ||
| "history_check_timeout": 1, | ||
| } | ||
|
|
||
| DUMMY_CHECK_STOP_TRADING_PARAMS = { | ||
| "disable_trading": True, | ||
| "stop_trading_if_staking_kpi_met": True, | ||
| } | ||
|
|
||
| DUMMY_STAKING_PARAMS = { | ||
| "staking_contract_address": "test", | ||
| "staking_interaction_sleep_time": 1, | ||
| "mech_activity_checker_contract": "test", | ||
| } |
There was a problem hiding this comment.
Might be better as fixtures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Models tests and tests for decision maker _io.loader and redeem_info