Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency management #687

Merged
merged 15 commits into from
Oct 27, 2023
Merged

Dependency management #687

merged 15 commits into from
Oct 27, 2023

Conversation

angrybayblade
Copy link

Proposed changes

This PR adds a script for managing dependencies across Pipfile, tox.ini, pyproject.toml, setup.py and packages

Fixes

If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to agents-aea?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Lint and unit tests pass locally with my changes and CI passes too
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that code coverage does not decrease.
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (1fb5f4e) 91.93% compared to head (84a7bb2) 91.94%.
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #687      +/-   ##
==========================================
+ Coverage   91.93%   91.94%   +0.01%     
==========================================
  Files         371      371              
  Lines       29646    29692      +46     
==========================================
+ Hits        27254    27301      +47     
+ Misses       2392     2391       -1     
Flag Coverage Δ
unittests 91.94% <98.36%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
aea/cli/check_packages.py 97.45% <ø> (+0.63%) ⬆️
aea/configurations/data_types.py 98.85% <98.36%> (+0.38%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@angrybayblade angrybayblade merged commit 4b8b28c into main Oct 27, 2023
34 of 36 checks passed
@DavidMinarsch DavidMinarsch deleted the feat/dependency-management branch November 16, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants