Fix misleading message on generate-key
#681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angrybayblade
commented
Oct 9, 2023
Comment on lines
+278
to
+285
| if len(crypto_registry.supported_ids) == 0: | ||
| raise click.ClickException("No ledger installation found") | ||
|
|
||
| if value not in crypto_registry.supported_ids and value != self.ALL: | ||
| raise click.ClickException( | ||
| f"Invalid identifier provided `{value}`; " | ||
| f"Available ledger identifiers {crypto_registry.supported_ids}" | ||
| ) |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #681 +/- ##
=======================================
Coverage 91.97% 91.97%
=======================================
Files 371 371
Lines 29591 29607 +16
=======================================
+ Hits 27216 27232 +16
Misses 2375 2375
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
jmoreira-valory
approved these changes
Oct 9, 2023
solarw
approved these changes
Oct 9, 2023
| @@ -259,6 +259,34 @@ def convert(self, value: str, param: Any, ctx: click.Context) -> Dependency: | |||
| raise click.ClickException(str(e)) from e | |||
|
|
|||
|
|
|||
| class LedgerChoice(click.ParamType): | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
Fixes
fixes #650
Types of changes
What types of changes does your code introduce to agents-aea?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply.developbranch (left side). Also you should start your branch off ourdevelop.