Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore tests directory when loading packages #676

Merged
merged 5 commits into from
Oct 5, 2023
Merged

Ignore tests directory when loading packages #676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9ae575a
feat: add flag to enable test dependency import checks
angrybayblade Oct 4, 2023
9b7ac05
fix: copyright
angrybayblade Oct 4, 2023
5f82281
Merge branch 'main' into fix/allow-test-imports-check
angrybayblade Oct 5, 2023
312a7ba
fix: ignore test directory when loading the packages
angrybayblade Oct 5, 2023
576b063
fix: copyright
angrybayblade Oct 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion aea/cli/check_packages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# -*- coding: utf-8 -*-
# ------------------------------------------------------------------------------
#
# Copyright 2022 Valory AG
# Copyright 2022-2023 Valory AG
# Copyright 2018-2021 Fetch.AI Limited
#
# Licensed under the Apache License, Version 2.0 (the "License");
Expand Down
6 changes: 4 additions & 2 deletions aea/components/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# -*- coding: utf-8 -*-
# ------------------------------------------------------------------------------
#
# Copyright 2022 Valory AG
# Copyright 2022-2023 Valory AG
# Copyright 2018-2021 Fetch.AI Limited
#
# Licensed under the Apache License, Version 2.0 (the "License");
Expand Down Expand Up @@ -350,8 +350,10 @@ def perform_load_aea_package(
)

prefix_pkg = prefix_pkg_type + f".{package_name}"

for subpackage_init_file in dir_.rglob("__init__.py"):
if subpackage_init_file.parent.name == "tests":
continue

parent_dir = subpackage_init_file.parent
relative_parent_dir = parent_dir.relative_to(dir_)
if relative_parent_dir == Path("."):
Expand Down
Loading