Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore tests directory when loading packages #676

Merged
merged 5 commits into from
Oct 5, 2023

Conversation

angrybayblade
Copy link

@angrybayblade angrybayblade commented Oct 4, 2023

Proposed changes

This issues mentioned below were caused by the check-package not checking the imports in the test directory, this PR adds a flag to check the test dependencies as well

Fixes

fixes #657
fixes #578

Types of changes

What types of changes does your code introduce to agents-aea?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Lint and unit tests pass locally with my changes and CI passes too
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that code coverage does not decrease.
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (2be89a7) 91.99% compared to head (9b7ac05) 91.99%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #676      +/-   ##
==========================================
- Coverage   91.99%   91.99%   -0.01%     
==========================================
  Files         371      371              
  Lines       29539    29541       +2     
==========================================
+ Hits        27175    27176       +1     
- Misses       2364     2365       +1     
Flag Coverage Δ
unittests 91.99% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
aea/cli/check_packages.py 96.83% <100.00%> (+0.02%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@angrybayblade angrybayblade changed the title Add flag to enable test dependency import checks Ignore tests directory when loading packages Oct 5, 2023
Copy link
Collaborator

@solarw solarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@angrybayblade angrybayblade merged commit a69aaf3 into main Oct 5, 2023
34 of 36 checks passed
@DavidMinarsch DavidMinarsch deleted the fix/allow-test-imports-check branch October 12, 2023 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve package dependency checks / unclear error message Investigate and fix check-packages command
4 participants