Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise when the dependency set size changes while fetching the agent #675

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

angrybayblade
Copy link

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.

Fixes

fixes #631

Types of changes

What types of changes does your code introduce to agents-aea?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Lint and unit tests pass locally with my changes and CI passes too
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that code coverage does not decrease.
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

DELETE INCLUSIVE THIS AND BELOW FOR STANDARD PR

Release summary

Version number: [e.g. 1.0.1]

Release details

Describe in short the main changes with the new release.

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the main branch (left side), from develop
  • Lint and unit tests pass locally and in CI
  • I have checked the fingerprint hashes are correct by running (aea packages lock --check)
  • I have regenerated the latest API docs
  • I built the documentation and updated it with the latest changes
  • I have added an item in HISTORY.md for this release
  • I bumped the version number in the aea/__version__.py file.
  • I bumped the version number in every Docker image of the repo and published it. Also, I built and published them with tag latest
    (check the READMEs of aea-develop
    and aea-user)
  • I have pushed the latest packages to the registry.
  • I have uploaded the latest aea to PyPI.
  • I have uploaded the latest plugins to PyPI.

Further comments

Write here any other comment about the release, if any.

@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (2be89a7) 91.99% compared to head (0364195) 91.98%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #675      +/-   ##
==========================================
- Coverage   91.99%   91.98%   -0.01%     
==========================================
  Files         371      371              
  Lines       29539    29545       +6     
==========================================
+ Hits        27175    27178       +3     
- Misses       2364     2367       +3     
Flag Coverage Δ
unittests 91.98% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
aea/cli/fetch.py 94.35% <66.66%> (-2.26%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@angrybayblade angrybayblade merged commit eea26fd into main Oct 4, 2023
36 checks passed
@DavidMinarsch DavidMinarsch deleted the fix/runtime-dep-set-change branch October 12, 2023 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RuntimeError when dependency is missing
3 participants