small validation error message formatting fix #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solarw
force-pushed
the
fix/better_error_msg_for_configuration_validation
branch
from
d0c1702 to
32337b4
Compare
solarw
commented
Feb 15, 2023
| @@ -243,7 +243,7 @@ def _validate(self, instance: Dict) -> None: | |||
| @staticmethod | |||
| def _build_message_from_errors(errors: List[jsonschema.ValidationError]) -> str: | |||
| """Build an error message from validation errors.""" | |||
| path = lambda error: ".".join(list(error.path)) # noqa # type: ignore | |||
| path = lambda error: "::".join(map(str, error.path)) # noqa | |||
There was a problem hiding this comment.
error was on constructing error message string.
There was a problem hiding this comment.
during the investigation another place of improvement was found:
#576
solarw
force-pushed
the
fix/better_error_msg_for_configuration_validation
branch
from
32337b4 to
901f201
Compare
Codecov ReportBase: 93.38% // Head: 93.38% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #575 +/- ##
==========================================
- Coverage 93.38% 93.38% -0.01%
==========================================
Files 353 353
Lines 28451 28451
==========================================
- Hits 26569 26568 -1
- Misses 1882 1883 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
angrybayblade
approved these changes
Feb 16, 2023
| @@ -243,7 +243,7 @@ def _validate(self, instance: Dict) -> None: | |||
| @staticmethod | |||
| def _build_message_from_errors(errors: List[jsonschema.ValidationError]) -> str: | |||
| """Build an error message from validation errors.""" | |||
| path = lambda error: ".".join(list(error.path)) # noqa # type: ignore | |||
| path = lambda error: "::".join(map(str, error.path)) # noqa | |||
There was a problem hiding this comment.
Suggested change
| path = lambda error: "::".join(map(str, error.path)) # noqa | |
| path = lambda error: ".".join(map(str, error.path)) # noqa |
DavidMinarsch
deleted the
fix/better_error_msg_for_configuration_validation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
small validation error message formatting fix
Fixes
#562
Types of changes
Checklist
Put an
xin the boxes that apply.developbranch (left side). Also you should start your branch off ourdevelop.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...
DELETE INCLUSIVE THIS AND BELOW FOR STANDARD PR
Release summary
Version number: [e.g. 1.0.1]
Release details
Describe in short the main changes with the new release.
Checklist
Put an
xin the boxes that apply.mainbranch (left side), fromdevelopaea packages lock --check)HISTORY.mdfor this releaseaea/__version__.pyfile.latest(check the READMEs of
aea-developand
aea-user)aeato PyPI.Further comments
Write here any other comment about the release, if any.