-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump tomte #543
chore: bump tomte #543
Changes from 4 commits
34a5617
4e9ca15
2035a0d
a67be6f
080376a
3dc94ba
4bd6520
32f0961
fe1617e
c87a0e1
ecabb83
26835e1
331c30a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
# -*- coding: utf-8 -*- | ||
# ------------------------------------------------------------------------------ | ||
# | ||
# Copyright 2022 Valory AG | ||
# Copyright 2022-2023 Valory AG | ||
# Copyright 2018-2021 Fetch.AI Limited | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
|
@@ -20,7 +20,7 @@ | |
"""Implementation of the 'aea fetch' subcommand.""" | ||
import os | ||
import shutil | ||
from distutils.dir_util import copy_tree | ||
from distutils.dir_util import copy_tree # pylint: disable=deprecated-module | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can't we use There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Probably |
||
from pathlib import Path | ||
from typing import Optional, Union, cast | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
# -*- coding: utf-8 -*- | ||
# ------------------------------------------------------------------------------ | ||
# | ||
# Copyright 2021-2022 Valory AG | ||
# Copyright 2021-2023 Valory AG | ||
# Copyright 2018-2019 Fetch.AI Limited | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
|
@@ -178,7 +178,7 @@ def _get_item_requirements( | |
:yield: package ids: (type, public_id) | ||
""" | ||
for item_type in map(str, ComponentType): | ||
items = getattr(item, f"{item_type}s", set()) | ||
items: Set[PublicId] = getattr(item, f"{item_type}s", set()) | ||
for item_public_id in items: | ||
if ignore_non_vendor and is_item_present( | ||
self._ctx.cwd, | ||
|
@@ -372,7 +372,7 @@ def remove(self) -> None: | |
@property | ||
def agent_items(self) -> Set[PublicId]: | ||
"""Return items registered with agent of the same type as item.""" | ||
return getattr(self.agent_config, self.item_type_plural, set) | ||
return getattr(self.agent_config, self.item_type_plural, set()) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. found a bug |
||
|
||
@property | ||
def is_required_by(self) -> bool: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make ci-requirements.txt and use
pip install -r
to make version edit easier?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. Will open a Trello ticket