chore: bump tomte #543

DavidMinarsch · 2023-01-14T21:28:19Z

Proposed changes

Bumps tomte to latest version.

Fixes

Types of changes

What types of changes does your code introduce to agents-aea?
Put an x in the boxes that apply

Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

I have read the CONTRIBUTING doc
I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
Lint and unit tests pass locally with my changes and CI passes too
I have added tests that prove my fix is effective or that my feature works
I have checked that code coverage does not decrease.
I have added necessary documentation (if appropriate)
Any dependent changes have been merged and published in downstream modules

Further comments

DavidMinarsch · 2023-01-14T21:31:17Z

setup.py

+        "pytest>=7.0.0,<7.3.0",
+        "coverage>=6.4.4,<8.0.0",


To match latest tomte ranges

DavidMinarsch · 2023-01-14T23:46:44Z

aea/cli/remove.py

@@ -372,7 +372,7 @@ def remove(self) -> None:
    @property
    def agent_items(self) -> Set[PublicId]:
        """Return items registered with agent of the same type as item."""
-        return getattr(self.agent_config, self.item_type_plural, set)
+        return getattr(self.agent_config, self.item_type_plural, set())


found a bug

DavidMinarsch · 2023-01-14T23:48:21Z

benchmark/checks/check_multiagent.py

-    for agent in agents:
-        wait_for_condition(lambda: agent.is_running, timeout=5)
+    for agent_ in agents:
+        wait_for_condition(lambda a=agent_: a.is_running, timeout=5)


this was a bug!

actually not a bug, it's used inplace. so closure is not needed.
but automatic check can suppose closure is needed.

DavidMinarsch · 2023-01-14T23:48:34Z

benchmark/checks/check_multiagent_http_dialogues.py

-    for agent in agents:
-        wait_for_condition(lambda: agent.is_running, timeout=5)
+    for agent_ in agents:
+        wait_for_condition(lambda a=agent_: a.is_running, timeout=5)


DavidMinarsch · 2023-01-14T23:52:55Z

plugins/aea-cli-benchmark/aea_cli_benchmark/case_multiagent/case.py

-    for agent in agents:
-        wait_for_condition(lambda: agent.is_running, timeout=5)
+    for agent_ in agents:
+        wait_for_condition(lambda a=agent_: a.is_running, timeout=5)


DavidMinarsch · 2023-01-14T23:53:06Z

plugins/aea-cli-benchmark/aea_cli_benchmark/case_multiagent_http_dialogues/case.py

-    for agent in agents:
-        wait_for_condition(lambda: agent.is_running, timeout=5)
+    for agent_ in agents:
+        wait_for_condition(lambda a=agent_: a.is_running, timeout=5)


DavidMinarsch · 2023-01-14T23:54:15Z

setup.cfg

@@ -13,7 +13,7 @@ exclude=.md,
    scripts/oef/launch.py
 max-line-length = 88
 select = B,C,D,E,F,I,W,
-ignore = E203,E501,W503,D202,B014,D400,D401,DAR
+ignore = E203,E501,W503,D202,B014,D400,D401,DAR,B028,B017


Need to enable at some point

DavidMinarsch · 2023-01-15T00:53:49Z

aea/launcher.py

@@ -173,7 +173,7 @@ def create_async_task(self, loop: AbstractEventLoop) -> TaskAwaitable:
            raise ValueError(
                "Agent runtime is not async compatible. Please use runtime_mode=async"
            )
-        return loop.create_task(self._agent.runtime.start_and_wait_completed())
+        return loop.create_task(self._agent.runtime.start_and_wait_completed())  # type: ignore


@solarw for you to investigate. I just added the ignore temporarily. It is masking an issue!

DavidMinarsch · 2023-01-15T00:53:57Z

aea/runner.py

@@ -79,7 +79,7 @@ def create_async_task(self, loop: AbstractEventLoop) -> TaskAwaitable:
            raise ValueError(
                "Agent runtime is not async compatible. Please use runtime_mode=async"
            )
-        return loop.create_task(self._agent.runtime.start_and_wait_completed())
+        return loop.create_task(self._agent.runtime.start_and_wait_completed())  # type: ignore


@solarw for you to investigate. I just added the ignore temporarily. It is masking an issue!

DavidMinarsch · 2023-01-15T00:54:49Z

scripts/check_ipfs_hashes_pushed.py



-def check_ipfs_hash_pushed(ipfs_hash: str) -> Tuple[str, bool]:
+def check_ipfs_hash_pushed(ipfs_hash: str, retries: int = 5) -> Tuple[str, bool]:


@8ball030 this should make you happy ;)

DavidMinarsch · 2023-01-15T17:54:31Z

packages/valory/connections/ledger/tests/conftest.py

@@ -126,7 +127,7 @@ def make_ledger_api_connection(
    return connection


-@pytest.fixture()


breaking change in this library

solarw · 2023-01-17T08:48:33Z

.github/workflows/workflow.yml

@@ -58,7 +58,7 @@ jobs:
          sudo apt-get update --fix-missing
          sudo apt-get autoremove
          sudo apt-get autoclean
-          pip install tomte[tox]==0.1.5
+          pip install tomte[tox]==0.2.2


make ci-requirements.txt and use pip install -r to make version edit easier?

Good idea. Will open a Trello ticket

solarw

LGTM

angrybayblade · 2023-01-17T09:57:34Z

aea/cli/fetch.py

@@ -20,7 +20,7 @@
 """Implementation of the 'aea fetch' subcommand."""
 import os
 import shutil
-from distutils.dir_util import copy_tree
+from distutils.dir_util import copy_tree  # pylint: disable=deprecated-module


Can't we use shutil.copytree here?

DavidMinarsch added 2 commits January 14, 2023 21:27

chore: bump tomte

34a5617

chore: apply new black formatting

4e9ca15

DavidMinarsch commented Jan 14, 2023

View reviewed changes

setup.py

Comment on lines +39 to +40

"pytest>=7.0.0,<7.3.0",

"coverage>=6.4.4,<8.0.0",

Copy link

Author

DavidMinarsch Jan 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To match latest tomte ranges

DavidMinarsch added 2 commits January 14, 2023 23:26

chore: address linter issues

2035a0d

chore: fix copyright and security linters

a67be6f

DavidMinarsch commented Jan 14, 2023

View reviewed changes

DavidMinarsch added 2 commits January 15, 2023 00:47

chore: addrss outstanding mypy issues

080376a

chore: update copyright headers

3dc94ba

DavidMinarsch commented Jan 15, 2023

View reviewed changes

DavidMinarsch added 5 commits January 15, 2023 00:59

chore: add python specific type check

4bd6520

chore: try again to ignore

32f0961

chore: remove python 3.8+ specific implementation

fe1617e

chore: fix doc test multiplexer-standalone.md

c87a0e1

chore: fix asyncio fixtures

ecabb83

DavidMinarsch commented Jan 15, 2023

View reviewed changes

DavidMinarsch added 2 commits January 16, 2023 22:13

Merge branch 'main' into tomte

26835e1

chore: fix hashes

331c30a

solarw reviewed Jan 17, 2023

View reviewed changes

solarw approved these changes Jan 17, 2023

View reviewed changes

angrybayblade approved these changes Jan 17, 2023

View reviewed changes

DavidMinarsch merged commit 05e0662 into main Jan 17, 2023

DavidMinarsch deleted the chore/tomte branch January 17, 2023 20:20

This was referenced Jan 19, 2023

use shutil.copytree instead of distutils.dir_util.copy_tree #553

Open

some type hints fixes after mypy update #554

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: bump tomte #543

chore: bump tomte #543

DavidMinarsch commented Jan 14, 2023

DavidMinarsch Jan 14, 2023

DavidMinarsch Jan 14, 2023

DavidMinarsch Jan 14, 2023

solarw Jan 19, 2023

DavidMinarsch Jan 14, 2023

solarw Jan 19, 2023

DavidMinarsch Jan 14, 2023

solarw Jan 19, 2023

DavidMinarsch Jan 14, 2023

solarw Jan 19, 2023

DavidMinarsch Jan 14, 2023

DavidMinarsch Jan 15, 2023

DavidMinarsch Jan 15, 2023

solarw Jan 19, 2023

DavidMinarsch Jan 15, 2023

DavidMinarsch Jan 15, 2023

solarw Jan 17, 2023

DavidMinarsch Jan 17, 2023

solarw left a comment

angrybayblade Jan 17, 2023

DavidMinarsch Jan 17, 2023



		def check_ipfs_hash_pushed(ipfs_hash: str) -> Tuple[str, bool]:
		def check_ipfs_hash_pushed(ipfs_hash: str, retries: int = 5) -> Tuple[str, bool]:

		@@ -126,7 +127,7 @@ def make_ledger_api_connection(
		return connection


		@pytest.fixture()

chore: bump tomte #543

chore: bump tomte #543

Conversation

DavidMinarsch commented Jan 14, 2023

Proposed changes

Fixes

Types of changes

Checklist

Further comments

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

solarw left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment