rating component does not support reactive forms (requires ngModel)

[born2net]

rating component does not support reactive forms (requires ngModel)
please change selector to <rating instead of [ngModel]

It implements ControlValueAccessor, but never provides NG_VALUE_ACCESSOR so that implementation is useless.

tx

Sean

Angular 2 Kitchen sink: http://ng2.javascriptninja.io
and source@ https://github.com/born2net/ng2Boilerplate

[born2net]

here is an example of how the components should be supported:
https://github.com/born2net/ng2Boilerplate/blob/master/src/comps/counterinputcomponent/CounterInputComponent.ts

[Martin-Luft]

The following ng2-bootstrap components use the ngModel selector binding:

pagination.component
pager.component
datepicker.component
datepicker-popup.component
button-checkbox.directive
button-radio.directive
timepicker.component
rating.component

[Martin-Luft]

What do you mean with

selector to <rating

Is the solution to use ngControl binding instead of ngModel binding?

[born2net]

if you look at the component, it uses ngModel, but reactive forms do not use ngModel, thus the directive does not bind to the component element.

[Martin-Luft]

#1023

[valorkin]

fixed with #298