Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"undefined" error in typeahead #345

Closed
slintes opened this issue Mar 30, 2016 · 1 comment
Closed

"undefined" error in typeahead #345

slintes opened this issue Mar 30, 2016 · 1 comment

Comments

@slintes
Copy link
Contributor

slintes commented Mar 30, 2016

Hi,

the value for the typeahead property of the typeahead component might be undefined sometimes in my app. Currently this gives an error in typeahead.directive.ts processMatches(), when it tries to get the length of typeahead.

PR follows.

Thanks for this otherwise great component :)

Greetings, Marc
@slintes
Copy link
Contributor Author

slintes commented Mar 30, 2016

see #346

valorkin added a commit that referenced this issue Mar 30, 2016
@valorkin
Merge pull request #346 from slintes/typeahead-undefined
c8a94a3 
Fixed potential error if value of typeahead is undefined. Fixes #345
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@slintes