Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DESCRIPTION file Error for Phyloseq #4

Closed
grabear opened this issue Sep 28, 2018 · 8 comments
Closed

DESCRIPTION file Error for Phyloseq #4

grabear opened this issue Sep 28, 2018 · 8 comments

Comments

@grabear
Copy link
Member

grabear commented Sep 28, 2018

I will try to reproduce this later, but I was having trouble building the package on my laptop. My laptop didn't have phyloseq installed at the time, and I was unable to build the package. I tried so many things in order to get it to install as a dependency of our package, but in the end I had to manually install it.

TODO:

  • Reproduce this bug.
  • Find a way to fix this bug
    • Installation hooks?
@grabear grabear changed the title Dependencies: Phyloseq Dependencies Error: Phyloseq Sep 28, 2018
@sdhutchins
Copy link
Contributor

Interesting. I'll test it out at home. R version maybe?

@grabear
Copy link
Member Author

grabear commented Sep 28, 2018

I don't think it's the R version, because I was able to install it manually. It's something to do with biocunductor or the DESCRIPTION file or devtools:: or remotes::....

I tried:

Remotes: bioc::phyloseq
Remotes: github::joey711/phyloseq
Imports: phyloseq
Depends: phyloseq
biocViews:
Additional_repositories:
    http://bioconductor.org/packages/release/bioc/,
    http://bioconductor.org/packages/release/data/annotation,
    http://bioconductor.org/packages/release/data/experiment,
    http://bioconductor.org/packages/release/extra

Anyways, here are some links:
r-lib/devtools#1401
https://cran.r-project.org/web/packages/devtools/vignettes/dependencies.html
https://github.com/r-lib/remotes
r-lib/devtools#1307
r-lib/devtools#700
r-infra/pkglock#6
ncchung/jackstraw#2

@sdhutchins
Copy link
Contributor

hmmmm

@sdhutchins
Copy link
Contributor

I added travis ci integration to help debug this a bit. https://travis-ci.com/vallenderlab/MicrobiomeR

@grabear
Copy link
Member Author

grabear commented Dec 17, 2018

#7

@grabear grabear changed the title Dependencies Error: Phyloseq DESCRIPTION file Error for Phyloseq Dec 17, 2018
@grabear
Copy link
Member Author

grabear commented Dec 17, 2018

As far as everything is currently going, I'm not having issues with this anymore. I'm not sure what fixed the problem, but I will look into this again, when we start testing.

@grabear
Copy link
Member Author

grabear commented Dec 19, 2018

What did you do to fix this? @sdhutchins

@sdhutchins
Copy link
Contributor

This has resolved itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants