Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we use Rust aliases to for compatibility bwn valkey-module and redis-module #10

Open
dmitrypol opened this issue Apr 29, 2024 · 1 comment

Comments

@dmitrypol
Copy link
Collaborator

As part of creating new valkey-module crate we forked redis-module and renamed a bunch of things. For example RedisString became ValkeyString. Should we implement Rust aliases https://doc.rust-lang.org/reference/items/type-aliases.html to hep with code compatibility?

If someone built a module in Rust for Redis using redis-module they can update their Cargo.toml to reference valkey-module. But they would have to make numerous updates in code. Aliases will simplify that.

@mkmkme
Copy link
Contributor

mkmkme commented Jul 5, 2024

I think having those type aliases would be great. If you want, I can come up with a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants