New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Check for Sender's Config Epoch Before Accepting Primary Claim #798

Open

PingXie opened this issue Jul 17, 2024 · 0 comments

Member

PingXie commented Jul 17, 2024

Also I think there is another (0-day) bug. We never check the sender's config epoch before accepting its claim of being a primary.

https://github.com/valkey-io/valkey/blob/unstable/src/cluster_legacy.c#L3119

Originally posted by @PingXie in #754 (comment)

PingXie mentioned this issue

Generate correct slot information in cluster shards command on primary failure #790

Merged

PingXie mentioned this issue

Avoid shard id update of replica if not matching with primary shard id #573

Open

PingXie mentioned this issue

Stale PONG message causes incorrect replicaof updates leading to replicaof loops #1015

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment