Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for Review of valkeyJSON Module #1354

Open
roshkhatri opened this issue Nov 25, 2024 · 3 comments
Open

Request for Review of valkeyJSON Module #1354

roshkhatri opened this issue Nov 25, 2024 · 3 comments

Comments

@roshkhatri
Copy link
Member

roshkhatri commented Nov 25, 2024

I would like to request a review of the ValkeyJSON module for inclusion in the valkey-io organization. This module has been implemented based on the specifications detailed in the accepted RFC document: ValkeyJSON Specification.

The module is currently hosted in my repository: ValkeyJSON Repository.

Please let me know if any additional documentation, context, or changes are required to facilitate this review. I look forward to your feedback and the next steps toward integrating this module.

@valkey-io/core-team, your input would be greatly appreciated.

UPDATE: PR for contributing the valkeyJSON module: valkey-io/valkeyJSON#1

Best regards,
Roshan

@PingXie
Copy link
Member

PingXie commented Nov 25, 2024

Logistic questions. How do we comment on the doc and the code without a PR? :)

How about creating a repo under Valkey and cutting a PR?

@roshkhatri
Copy link
Member Author

Sure I will do that asap. Can you create a repo under valkey with the name of valkeyJSON so I can open a PR for it?

@roshkhatri
Copy link
Member Author

Wait I can do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants