Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Applying and Restoring to different executables. #63

Open
TheJaredWilcurt opened this issue Nov 22, 2024 · 1 comment
Open

Comments

@TheJaredWilcurt
Copy link

TheJaredWilcurt commented Nov 22, 2024

Problem

In this, very long issue:

Everyone is running into the same problem.

  1. Run the exe, works great
  2. Windows forces you to do updates
  3. Upon rebooting, the patched file is unpatched, causing rounded corners to return
  4. Try re-running the executable, it fails because a .bak file exists
  5. Manually delete a file from system32 (fun)
  6. Re-run the executable and it works now.

Solution

Instead of shipping just one executable:

  • Win11DisableOrRestoreRoundedCorners.exe

Ship 2 separate executables:

  • Win11DisableRoundedCorners.exe
  • Win11RestoreRoundedCorners.exe

This will avoid many issues in the future, including the current one.

It puts all the power into the hands of the users to pick what their intent is very clearly.

Should simplify code, as you have two simple tasks to do, instead of having to "guess" what the user wants.

@TheJaredWilcurt
Copy link
Author

TheJaredWilcurt commented Nov 22, 2024

I'm also cool with it always disabling rounded corners every time it is ran, unless you pass in a -restore argument, as seen in this PR:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant