feat(isLicensePlate): added License Plate Regex for en-IN and all Indian locale #1944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1944 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 102 102
Lines 2085 2099 +14
Branches 472 472
=========================================
+ Hits 2085 2099 +14
Continue to review full report at Codecov.
|
NishantJS
changed the title
rubiin
approved these changes
Jul 18, 2022
|
Thankyou for the contribution 🎉 |
profnandaa
reviewed
Jan 31, 2023
| }; | ||
|
|
||
| validators['hi-IN'] = validators['en-IN']; |
There was a problem hiding this comment.
nit: missed this review, perhaps this wasn't necessary. At some point, we actually contemplated to just use country-code only in the locales for stuff like license plates, that really don't depend on language per se.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for Indian license plate validation. Valid examples from Wikipedia:
MH 04 AZ 4562
MH : STATE_CODE
04 : DISTRICT_CODE
AZ : UNIQUE_LETTERS
4562 : UNIQUE_NUMBERING
Basically all options can be written with dash, with space or all together or without symbol.