-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(isMACAddress): add EUI-64 validation #1865
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1865 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 102 102
Lines 2059 2072 +13
Branches 464 472 +8
=========================================
+ Hits 2059 2072 +13
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR @WikiRik !
Can you please address my comments?
I'm also wondering if EUI-48/64 is the most used technical term.Personally, I know it as MacAddr6
and MacAddr8
.
To be honest, I do not really know. I would be happy to refer to it as MacAddr6 and 8. Do you think I should refactor it to numberOfBits? Or some other suggestion? |
Co-authored-by: Sarhan Aissi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉 Thank you for your efforts @WikiRik !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your contrib! 🎉
This PR adds support for validating against EUI-64 as well as the previous EUI-48. This corresponds with the macaddr8 type in postgres.
Checklist