#349: update stories to typescript #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mob8607
changed the title
mob8607
changed the title
…349_storybook-typescript Conflicts: package.json src/plugins/v-focus/styles/styles.scss src/stories/elements/e-button.stories.ts src/stories/elements/e-checkbox.stories.ts src/stories/elements/e-video.stories.ts
benjamin-joham
approved these changes
May 23, 2024
Comment on lines
+10
to
+11
| "fix:eslint": "npm run lint:eslint -- --config .eslintrc.fix.cjs --cache=false --fix", | ||
| "fix:stylelint": "npm run lint:stylelint -- --cache=false --config .stylelintrc.fix.js --fix", |
There was a problem hiding this comment.
question: are these triggered in the pre-commit hook or just here for manual execution?
There was a problem hiding this comment.
They are for manual execution
| render: (args) => ({ | ||
| const Template: StoryObj = { | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| render: (args: any) => ({ |
There was a problem hiding this comment.
note: I don't like having any here. But I think for now it is sufficient enough.
There was a problem hiding this comment.
I couldn't get it to work without it. Maybe I missed something here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Refactors storybook stories to typescript.
Ticket
#349
Browser testing
Checklist
Review/Test checklist