Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.4 remove warnings from implicitly nullable parameters #2832

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

PHP 8.4 remove warnings from implicitly nullable parameters #2832

wants to merge 2 commits into from

Conversation

brezocordero
Copy link
Contributor

@brezocordero brezocordero commented Nov 23, 2024 •
edited
Loading

Changes proposed in this Pull Request:

Closes #2822 .

Fix implicitly nullable parameters

  • Do the changed files pass phpcs checks? Please remove phpcs:ignore comments in changed files and fix any issues, or delete if not practical.

Changelog entry

Tweak: PHP 8.4 compatibility.

@github-actions github-actions bot added the changelog: tweak Small change, that isn't actually very important. label Nov 23, 2024
@brezocordero brezocordero mentioned this pull request Nov 23, 2024
Open
@brezocordero brezocordero requested a review from a team November 23, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changelog: tweak Small change, that isn't actually very important.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHP 8.4 compatibility issues
1 participant
@brezocordero