Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onHighlight prop #10

Open
chrisforrette opened this issue Nov 14, 2018 · 4 comments
Open

Add onHighlight prop #10

chrisforrette opened this issue Nov 14, 2018 · 4 comments

Comments

@chrisforrette
Copy link

Hey there. This and the rest of ink has been really rad, thanks for all your hard work!

It would be pretty nice (and helpful for a current project) to have the ability to pass an onHighlight prop (or something like that) that would be invoked when an item is highlighted, e.g. when the up or down arrows are pressed (but not when enter is pressed), and I'd be happy to get a PR together for it if it's something you're open to. Let me know what you think, thanks!

@SimenB
Copy link

SimenB commented Mar 9, 2019

I'd also like to have this. I wanna print how many items there are left to scroll down to (using limit)

@zimme
Copy link
Contributor

zimme commented Mar 14, 2019

I would suggest this being called onChange.

@zimme
Copy link
Contributor

zimme commented Mar 23, 2019

There's a PR for this here #16 and as I was out voted on the name, it's called onHighlight =)

@vadimdemedes
Copy link
Owner

Fixed via #16, will keep this issue open until new release is out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants