Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't send duplicate messages to IHAVE-announcing peers #867

Closed
arnetheduck opened this issue Feb 22, 2023 · 2 comments
Closed

Don't send duplicate messages to IHAVE-announcing peers #867

arnetheduck opened this issue Feb 22, 2023 · 2 comments
Labels
gossipsub performance performance and resource ussage

Comments

@arnetheduck
Copy link
Contributor

As a subset of #859, we should not be rebroadcasting messages to peers that have announced they have it via IHAVE - this applies for IHAVE's received during async validation in particular
@Menduist
Copy link
Contributor

Peers don't sent IHAVEs to peers inside their mesh, so that situation shouldn't happen currently

My proposal #859 (comment) here assumes a slight spec change to send IHAVE to peers in mesh for big messages

@arnetheduck arnetheduck added the performance performance and resource ussage label Mar 8, 2023
@Menduist
Copy link
Contributor

In the current and planned gossipsub specs, you don't send an IHAVE to your mesh, so this optimization doesn't seem necessary at this point

@kaiserd kaiserd moved this to new in nim-libp2p May 2, 2024
@kaiserd kaiserd moved this from new to done in nim-libp2p May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gossipsub performance performance and resource ussage
Projects
nim-libp2p
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arnetheduck @Menduist